Bug 1970415: Document SR-IOV use case: using network with port security disabled by iamemilio · Pull Request #4958 · openshift/installer

iamemilio · 2021-05-25T19:09:07Z

This use case requires a unique usage pattern in comparison to what the
customer may be use to, so we chose to document it in its entirety to
avoid any confusion down the line.

docs/user/openstack/deploy_sriov_workers.md

EmilienM · 2021-05-26T14:25:22Z

/approve

Fedosin · 2021-05-26T15:15:34Z

docs/user/openstack/deploy_sriov_workers.md

s/definiton/definition/g

Longest line I've seen in a while 😮

Also, I'll be honest, I find this paragraph quite hard to follow. Perhaps you should break the Creating SR-IOV Worker Nodes in IPI section into two sub-sections:

deployment on networks with port security enabled

deployment on networks with port security disabled

You should also update line 129 to reference this new section.

rephrase and drop references to "we" and "you"
for example:
"we recommend disabling the port " => " disable port security"
or
"However, if your architecture" => " If the architecture"
In other words be more direct with statements, it will allow the paragraph to be smaller and clearer.
also who is "we"?

the networks and subnets interfaces in the machine API => the networks and subnets sections of the machineset.

EmilienM · 2021-06-08T19:40:26Z

docs/user/openstack/deploy_sriov_workers.md

this line is too long, please split like it was previously suggested.

This use case requires a unique usage pattern in comparison to what the customer may be use to, so we chose to document it in its entirety to avoid any confusion down the line.

EmilienM · 2021-06-09T13:44:22Z

/lgtm

openshift-ci · 2021-06-09T13:48:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~docs/user/openstack/OWNERS~~ [EmilienM]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mandre

/lgtm
Please reference a valid BZ if you want this to merge before the 4.8 code freeze.

openshift-ci · 2021-06-10T12:56:53Z

@iamemilio: This pull request references Bugzilla bug 1970415, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1970415: Document SR-IOV use case: using network with port security disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

iamemilio · 2021-06-10T12:57:35Z

/bugzilla refresh

openshift-ci · 2021-06-10T12:57:46Z

@iamemilio: This pull request references Bugzilla bug 1970415, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

iamemilio · 2021-06-10T12:58:23Z

/bugzilla refresh

openshift-ci · 2021-06-10T12:58:28Z

@iamemilio: This pull request references Bugzilla bug 1970415, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

iamemilio · 2021-06-10T12:59:39Z

/bugzilla refresh

openshift-ci · 2021-06-10T12:59:46Z

@iamemilio: This pull request references Bugzilla bug 1970415, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-06-10T13:02:20Z

@iamemilio: All pull requests linked via external trackers have merged:

openshift/installer#4958

Bugzilla bug 1970415 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1970415: Document SR-IOV use case: using network with port security disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from Fedosin and adduarte May 25, 2021 19:09

maxwelldb reviewed May 25, 2021

View reviewed changes

docs/user/openstack/deploy_sriov_workers.md Outdated Show resolved Hide resolved

iamemilio force-pushed the sriov_portsec_special_case branch from 787f7c1 to 77dba44 Compare May 25, 2021 19:23

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2021

Fedosin reviewed May 26, 2021

View reviewed changes

mandre mentioned this pull request Jun 1, 2021

Add SR-IOV notes specific to Kuryr #4957

Closed

iamemilio force-pushed the sriov_portsec_special_case branch 3 times, most recently from c3f2f35 to 224d59f Compare June 8, 2021 18:09

EmilienM reviewed Jun 8, 2021

View reviewed changes

docs/user/openstack/deploy_sriov_workers.md Outdated

Copy link

Member

EmilienM Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is too long, please split like it was previously suggested.

iamemilio force-pushed the sriov_portsec_special_case branch from 224d59f to bf9b9a1 Compare June 9, 2021 13:38

Document SR-IOV use case: using network with port security disabled

29f3601

This use case requires a unique usage pattern in comparison to what the customer may be use to, so we chose to document it in its entirety to avoid any confusion down the line.

iamemilio force-pushed the sriov_portsec_special_case branch from bf9b9a1 to 29f3601 Compare June 9, 2021 13:42

openshift-ci bot assigned EmilienM Jun 9, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021

mandre reviewed Jun 10, 2021

View reviewed changes

openshift-ci bot assigned mandre Jun 10, 2021

iamemilio changed the title ~~Document SR-IOV use case: using network with port security disabled~~ Bug 1970415: Document SR-IOV use case: using network with port security disabled Jun 10, 2021

openshift-ci bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jun 10, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 10, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 10, 2021

openshift-ci bot requested a review from eurijon June 10, 2021 12:57

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Jun 10, 2021

openshift-merge-robot merged commit b37dc09 into openshift:master Jun 10, 2021

Conversation

iamemilio commented May 25, 2021

Uh oh!

Uh oh!

EmilienM commented May 26, 2021

Uh oh!

Fedosin May 26, 2021

Choose a reason for hiding this comment

Uh oh!

mandre May 27, 2021

Choose a reason for hiding this comment

Uh oh!

adduarte Jun 3, 2021

Choose a reason for hiding this comment

Uh oh!

EmilienM Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

EmilienM commented Jun 9, 2021

Uh oh!

openshift-ci bot commented Jun 9, 2021

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jun 10, 2021

Uh oh!

iamemilio commented Jun 10, 2021

Uh oh!

openshift-ci bot commented Jun 10, 2021

Uh oh!

iamemilio commented Jun 10, 2021

Uh oh!

openshift-ci bot commented Jun 10, 2021

Uh oh!

iamemilio commented Jun 10, 2021

Uh oh!

openshift-ci bot commented Jun 10, 2021

Uh oh!

openshift-ci bot commented Jun 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants