Skip to content

asset/store: try to reuse assets from state file#536

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
crawford:reuse
Oct 25, 2018
Merged

asset/store: try to reuse assets from state file#536
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
crawford:reuse

Conversation

@crawford
Copy link
Contributor

@crawford crawford commented Oct 25, 2018

Before this change, when the installer found an asset in both the target
directory and the state file, it assumed that the asset should be dirty,
causing the asset and all of its dependants to be regenerated. This is a
small optimization that prevents regenerating dependant assets when the
provided asset is identical to the one in the state file.

@crawford
asset/store: try to reuse assets from state file
6514da4 
Before this change, when the installer found an asset in both the target
directory and the state file, it assumed that the asset should be dirty,
causing the asset and all of its dependants to be regenerated. This is a
small optimization that prevents regenerating dependant assets when the
provided asset is identical to the one in the state file.
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 25, 2018
@crawford
Copy link
Contributor Author

crawford commented Oct 25, 2018

/retest

abhinavdahiya
abhinavdahiya approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@abhinavdahiya abhinavdahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

rajatchopra
rajatchopra approved these changes Oct 25, 2018
View reviewed changes
Copy link

@rajatchopra rajatchopra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford, rajatchopra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford,rajatchopra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crawford
Copy link
Contributor Author

crawford commented Oct 25, 2018 •
edited
Loading

Failed to bring up the API and failed to tear down:

• Failure in Spec Setup (BeforeEach) [127.958 seconds]
[sig-storage] Secrets
/tmp/openshift/build-rpms/rpm/BUILD/origin-4.0.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/common/secrets_volume.go:33
  should be consumable from pods in volume with defaultMode set [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s] [BeforeEach]
  /tmp/openshift/build-rpms/rpm/BUILD/origin-4.0.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:684

  Expected error:
      <*errors.errorString | 0xc4200d1560>: {
          s: "timed out waiting for the condition",
      }
      timed out waiting for the condition
  not to have occurred

  /tmp/openshift/build-rpms/rpm/BUILD/origin-4.0.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:217

/retest

@crawford
Copy link
Contributor Author

crawford commented Oct 25, 2018 

Waiting for API at https://ci-op-bim4i366-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443 to respond ...
NAME                          STATUS    ROLES     AGE       VERSION
ip-10-0-13-201.ec2.internal   Ready     master    9m        v1.11.0+d4cacc0
ip-10-0-23-17.ec2.internal    Ready     master    8m        v1.11.0+d4cacc0
ip-10-0-45-158.ec2.internal   Ready     master    9m        v1.11.0+d4cacc0
API at https://ci-op-bim4i366-1d3f3-api.origin-ci-int-aws.dev.rhcloud.com:6443 has responded
NAME      DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
router    1         1         1            0           4m
Found router in openshift-ingress
Waiting for deployment "router" rollout to finish: 0 of 1 updated replicas are available...
error: watch closed before Until timeout
Waiting for deployment "router" rollout to finish: 0 of 1 updated replicas are available...
error openshift-ingress/deploy/router did not come up
Waiting for deployment "router" rollout to finish: 0 of 1 updated replicas are available...
Waiting for deployment "router" rollout to finish: 0 of 1 updated replicas are available...
error: watch closed before Until timeout
error openshift-ingress/deploy/router did not come up
Waiting for deployment "router" rollout to finish: 0 of 1 updated replicas are available...
Waiting for deployment "router" rollout to finish: 0 of 1 updated replicas are available...
error: watch closed before Until timeout
error openshift-ingress/deploy/router did not come up
Waiting for deployment "router" rollout to finish: 0 of 1 updated replicas are available...
Waiting for deployment "router" rollout to finish: 0 of 1 updated replicas are available...
error: watch closed before Until timeout
error openshift-ingress/deploy/router did not come up
error: deployment "router" exceeded its progress deadline
error openshift-ingress/deploy/router did not come up
error: deployment "router" exceeded its progress deadline
error openshift-ingress/deploy/router did not come up
error: deployment "router" exceeded its progress deadline
error openshift-ingress/deploy/router did not come up
error: deployment "router" exceeded its progress deadline
error openshift-ingress/deploy/router did not come up
error: deployment "router" exceeded its progress deadline
error openshift-ingress/deploy/router did not come up
error: deployment "router" exceeded its progress deadline
timeout waiting for openshift-ingress/deploy/router to be available
2018/10/25 18:35:28 Container test in pod e2e-aws failed, exit code 1, reason Error

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 25, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 408cf66 into openshift:master Oct 25, 2018
@crawford crawford deleted the reuse branch October 25, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@staebler staebler Awaiting requested review from staebler

2 more reviewers

@rajatchopra rajatchopra rajatchopra approved these changes

@abhinavdahiya abhinavdahiya abhinavdahiya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rajatchopra rajatchopra

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crawford @openshift-ci-robot @openshift-merge-robot @rajatchopra @abhinavdahiya