Skip to content

Bug 2082283: Transition to the oVirt Terraform provider v2#5867

Merged
openshift-ci[bot] merged 1 commit intomasterfrom
unknown repository
Jun 22, 2022
Merged

Bug 2082283: Transition to the oVirt Terraform provider v2#5867
openshift-ci[bot] merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented May 5, 2022 •
edited by ghost
Loading

This PR transitions the OpenShift installer to the new oVirt Terraform provider, which brings better logging, stability improvements, and fixes several bugs.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

@janosdebugs: This pull request references Bugzilla bug 2082283, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2082283: Transition to the oVirt Terraform provider v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bkhizgiy and mmartinv May 5, 2022 18:08
@ghost
Copy link
Author

ghost commented May 5, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

@janosdebugs: This pull request references Bugzilla bug 2082283, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (mburman@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 6, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@ghost
Copy link
Author

ghost commented May 30, 2022

/test e2e-ovirt

@ghost ghost marked this pull request as ready for review May 30, 2022 10:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2022
@ghost ghost changed the title Bug 2082283: Transition to the oVirt Terraform provider v2 WIP: Bug 2082283: Transition to the oVirt Terraform provider v2 May 30, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2022
@ghost
Copy link
Author

ghost commented May 30, 2022

/retest-required

@openshift-ci openshift-ci bot requested a review from eslutsky May 30, 2022 10:03
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2022
@ghost
Copy link
Author

ghost commented May 30, 2022

/test e2e-ovirt

eslutsky
eslutsky reviewed May 30, 2022
View reviewed changes
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2022
@ghost
Copy link
Author

ghost commented Jun 1, 2022

/retest e2e-ovirt

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@janosdebugs: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-metal-ipi-ovn-ipv6
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-alibaba
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-proxy
  • /test e2e-aws-shared-vpc
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upi
  • /test e2e-aws-upi-proxy
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure
  • /test e2e-azure-resourcegroup
  • /test e2e-azure-shared-vpc
  • /test e2e-azure-upi
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp
  • /test e2e-gcp-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud
  • /test e2e-libvirt
  • /test e2e-metal
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-swapped-hosts
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-openstack
  • /test e2e-openstack-kuryr
  • /test e2e-openstack-parallel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-upi
  • /test e2e-ovirt
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test okd-e2e-aws
  • /test okd-e2e-aws-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-upgrade
  • /test okd-e2e-vsphere
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-e2e-aws
  • pull-ci-openshift-installer-master-e2e-aws-fips
  • pull-ci-openshift-installer-master-e2e-aws-proxy
  • pull-ci-openshift-installer-master-e2e-aws-shared-vpc
  • pull-ci-openshift-installer-master-e2e-aws-single-node
  • pull-ci-openshift-installer-master-e2e-azure
  • pull-ci-openshift-installer-master-e2e-crc
  • pull-ci-openshift-installer-master-e2e-gcp
  • pull-ci-openshift-installer-master-e2e-ibmcloud
  • pull-ci-openshift-installer-master-e2e-libvirt
  • pull-ci-openshift-installer-master-e2e-metal-assisted
  • pull-ci-openshift-installer-master-e2e-metal-ipi
  • pull-ci-openshift-installer-master-e2e-openstack
  • pull-ci-openshift-installer-master-e2e-ovirt
  • pull-ci-openshift-installer-master-e2e-vsphere
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint
Details

In response to this:

/retest e2e-ovirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link
Author

ghost commented Jun 1, 2022

/test e2e-ovirt

2 similar comments
@engelmi
Copy link
Contributor

engelmi commented Jun 1, 2022

/test e2e-ovirt

@engelmi
Copy link
Contributor

engelmi commented Jun 2, 2022

/test e2e-ovirt

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2022

@janosdebugs: This pull request references Bugzilla bug 2082283, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (mburman@redhat.com), skipping review request.

Details

In response to this:

WIP: Bug 2082283: Transition to the oVirt Terraform provider v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@engelmi
Copy link
Contributor

engelmi commented Jun 8, 2022

/test e2e-ovirt

1 similar comment
@eslutsky
Copy link
Contributor

eslutsky commented Jun 8, 2022

/test e2e-ovirt

@ghost ghost changed the title WIP: Bug 2082283: Transition to the oVirt Terraform provider v2 Bug 2082283: Transition to the oVirt Terraform provider v2 Jun 20, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2022
@engelmi
oVirt: Terraform code changes for TF v2
d27d60d 
This change updates the Terraform code to match the syntax of the oVirt Terraform provider version 2.

Fixes bug 2082283

Signed-off-by: Janos Bonic <86970079+janosdebugs@users.noreply.github.com>
@eslutsky
Copy link
Contributor

eslutsky commented Jun 20, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2022

@janosdebugs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt d27d60d link false /test e2e-libvirt
ci/prow/e2e-crc d27d60d link false /test e2e-crc
ci/prow/e2e-ibmcloud d27d60d link false /test e2e-ibmcloud
ci/prow/e2e-openstack d27d60d link false /test e2e-openstack
ci/prow/e2e-vsphere d27d60d link false /test e2e-vsphere

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ghost
Copy link
Author

ghost commented Jun 20, 2022

/assign @patrickdillon

@patrickdillon
Copy link
Contributor

patrickdillon commented Jun 22, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022
@openshift-ci openshift-ci bot merged commit 9c9b904 into openshift:master Jun 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2022

@janosdebugs: All pull requests linked via external trackers have merged:

Bugzilla bug 2082283 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2082283: Transition to the oVirt Terraform provider v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkhizgiy bkhizgiy Awaiting requested review from bkhizgiy

@mmartinv mmartinv Awaiting requested review from mmartinv

Assignees

@patrickdillon patrickdillon

@eslutsky eslutsky

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@engelmi @eslutsky @patrickdillon