cmd/openshift-install/create: don't log nil errors#603
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Nov 2, 2018
crawford:err
Merged
cmd/openshift-install/create: don't log nil errors#603openshift-merge-robot merged 1 commit intoopenshift:masterfrom crawford:err
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
crawford:err
Conversation
The call to cancel isn't a synchronous operation and the closure
executes to completion. As a result, the debug call which logs the error
should be in an else branch so it isn't printed if there is no error.
Without this change, the following would show up in the log:
INFO API v1.11.0+d4cacc0 up
DEBUG API not up yet: %!s(<nil>)
openshift-ci-robot
added
approved
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to cancel isn't a synchronous operation and the closure
executes to completion. As a result, the debug call which logs the error
should be in an else branch so it isn't printed if there is no error.
Without this change, the following would show up in the log: