Skip to content

CORS-2167: Remove UPI Metal TF references#6174

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
barbacbd:remove_upi_metal_tf_and_docs
Aug 1, 2022
Merged

CORS-2167: Remove UPI Metal TF references#6174
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
barbacbd:remove_upi_metal_tf_and_docs

Conversation

@barbacbd
Copy link
Contributor

** Removed the Example and terraform data in upi/metal
** Updated the docs in docs/user/metal to reflect the changes above. Pointing the user towards the official docs.

** Removed the Example and terraform data in upi/metal
** Updated the docs in docs/user/metal to reflect the changes above. Pointing the user towards the official docs.
@openshift-ci openshift-ci bot requested review from andfasano and sadasu July 27, 2022 17:23
@sadasu
Copy link
Contributor

sadasu commented Jul 27, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2022

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws a0e75fe link false /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor

r4f4 commented Jul 28, 2022

Is there a reason to keep the empty metal directory around?

@barbacbd
Copy link
Contributor Author

barbacbd commented Aug 1, 2022

There is not. I dont know why it remained I deleted it.

@barbacbd
Copy link
Contributor Author

barbacbd commented Aug 1, 2022

Git does not track directories that are empty. I think this is just a local copy from your system. I cannot delete something from git that git does not think exists at this point.

@r4f4
Copy link
Contributor

r4f4 commented Aug 1, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit e4519dc into openshift:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants