Skip to content

OCPBUGS-13636: new Aws secret regions support#6184

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
r4f4:aws-secret-regions
Jun 21, 2023
Merged

OCPBUGS-13636: new Aws secret regions support#6184
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
r4f4:aws-secret-regions

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Jul 29, 2022

Add support for SC2S region (us-isob-east-1) and new TC2S region (us-iso-west-1).

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2022

@r4f4: This pull request references Bugzilla bug 2112007, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2112007: new Aws secret regions support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jstuever and patrickdillon July 29, 2022 13:53
@r4f4
Copy link
Contributor Author

r4f4 commented Aug 1, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

@r4f4: This pull request references Bugzilla bug 2112007, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gpei@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@barbacbd
Copy link
Contributor

barbacbd commented Aug 1, 2022

/cc barbacbd

@openshift-ci openshift-ci bot requested a review from barbacbd August 1, 2022 17:58
@barbacbd
Copy link
Contributor

barbacbd commented Aug 1, 2022

/uncc barbacbd

@openshift-ci openshift-ci bot removed the request for review from barbacbd August 1, 2022 18:03
@jstuever
Copy link
Contributor

jstuever commented Aug 1, 2022

/retest

@sadasu
Copy link
Contributor

sadasu commented Sep 26, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2022
@r4f4
Copy link
Contributor Author

r4f4 commented Sep 26, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2022
@jstuever
Copy link
Contributor

/cc @patrickdillon
/uncc

@openshift-ci openshift-ci bot removed the request for review from jstuever October 12, 2022 16:06
@yunjiang29
Copy link
Contributor

Hello @r4f4 pre-merge test failed with error Unsupported Operation

install logs:

10-19 18:15:01.781  level=debug msg=module.iam.aws_iam_role.worker_role[0]: Still creating... [1h2m11s elapsed]
10-19 18:15:03.710  level=error
10-19 18:15:03.710  level=error msg=Error: failed creating IAM Role (yunjiang-57c2s2-fmjqq-worker-role): RequestError: send request failed
10-19 18:15:03.710  level=error msg=caused by: Post "https://iam.us-iso-east-1.c2s.ic.gov/": Service Unavailable
10-19 18:15:03.710  level=error
10-19 18:15:03.710  level=error msg=  with module.iam.aws_iam_role.worker_role[0],
10-19 18:15:03.710  level=error msg=  on iam/main.tf line 13, in resource "aws_iam_role" "worker_role":
10-19 18:15:03.710  level=error msg=  13: resource "aws_iam_role" "worker_role" {
10-19 18:15:03.710  level=error
10-19 18:15:03.710  level=error
10-19 18:15:03.710  level=error msg=Error: failed creating IAM Role (yunjiang-57c2s2-fmjqq-master-role): RequestError: send request failed
10-19 18:15:03.710  level=error msg=caused by: Post "https://iam.us-iso-east-1.c2s.ic.gov/": Service Unavailable
10-19 18:15:03.710  level=error
10-19 18:15:03.710  level=error msg=  with module.masters.aws_iam_role.master_role[0],
10-19 18:15:03.710  level=error msg=  on master/main.tf line 18, in resource "aws_iam_role" "master_role":
10-19 18:15:03.710  level=error msg=  18: resource "aws_iam_role" "master_role" {
10-19 18:15:03.710  level=error
10-19 18:15:03.710  level=error
10-19 18:15:03.710  level=error msg=Error: error creating Route53 Hosted Zone: SerializationError: failed to unmarshal error message
10-19 18:15:03.710  level=error msg=	status code: 400, request id: 
10-19 18:15:03.710  level=error msg=caused by: UnmarshalError: failed to unmarshal error message
10-19 18:15:03.710  level=error msg=	00000000  3c 3f 78 6d 6c 20 76 65  72 73 69 6f 6e 3d 22 31  |<?xml version="1|
10-19 18:15:03.710  level=error msg=00000010  2e 30 22 20 65 6e 63 6f  64 69 6e 67 3d 22 55 54  |.0" encoding="UT|
10-19 18:15:03.710  level=error msg=00000020  46 2d 38 22 20 73 74 61  6e 64 61 6c 6f 6e 65 3d  |F-8" standalone=|
10-19 18:15:03.710  level=error msg=00000030  22 6e 6f 22 3f 3e 3c 52  65 73 70 6f 6e 73 65 3e  |"no"?><Response>|
10-19 18:15:03.710  level=error msg=00000040  3c 45 72 72 6f 72 73 3e  3c 45 72 72 6f 72 3e 3c  |<Errors><Error><|
10-19 18:15:03.710  level=error msg=00000050  43 6f 64 65 3e 55 6e 73  75 70 70 6f 72 74 65 64  |Code>Unsupported|
10-19 18:15:03.710  level=error msg=00000060  4f 70 65 72 61 74 69 6f  6e 3c 2f 43 6f 64 65 3e  |Operation</Code>|
10-19 18:15:03.711  level=error msg=00000070  3c 4d 65 73 73 61 67 65  3e 54 68 65 20 66 75 6e  |<Message>The fun|
10-19 18:15:03.711  level=error msg=00000080  63 74 69 6f 6e 61 6c 69  74 79 20 79 6f 75 20 72  |ctionality you r|
10-19 18:15:03.711  level=error msg=00000090  65 71 75 65 73 74 65 64  20 69 73 20 6e 6f 74 20  |equested is not |
10-19 18:15:03.711  level=error msg=000000a0  61 76 61 69 6c 61 62 6c  65 20 69 6e 20 74 68 69  |available in thi|
10-19 18:15:03.711  level=error msg=000000b0  73 20 72 65 67 69 6f 6e  2e 3c 2f 4d 65 73 73 61  |s region.</Messa|
10-19 18:15:03.711  level=error msg=000000c0  67 65 3e 3c 2f 45 72 72  6f 72 3e 3c 52 65 71 75  |ge></Error><Requ|
10-19 18:15:03.711  level=error msg=000000d0  65 73 74 49 44 3e 63 64  38 31 39 36 33 64 64 37  |estID>cd81963dd7|
10-19 18:15:03.711  level=error msg=000000e0  66 31 34 61 37 62 39 31  38 33 37 61 35 38 38 31  |f14a7b91837a5881|
10-19 18:15:03.711  level=error msg=000000f0  65 32 34 35 32 34 3c 2f  52 65 71 75 65 73 74 49  |e24524</RequestI|
10-19 18:15:03.711  level=error msg=00000100  44 3e 3c 2f 45 72 72 6f  72 73 3e 3c 2f 52 65 73  |D></Errors></Res|
10-19 18:15:03.711  level=error msg=00000110  70 6f 6e 73 65 3e                                 |ponse>|
10-19 18:15:03.711  level=error
10-19 18:15:03.711  level=error msg=caused by: unknown error response tag, {{ Response} []}
10-19 18:15:03.711  level=error
10-19 18:15:03.711  level=error msg=  with module.dns.aws_route53_zone.new_int[0],
10-19 18:15:03.711  level=error msg=  on route53/base.tf line 24, in resource "aws_route53_zone" "new_int":
10-19 18:15:03.711  level=error msg=  24: resource "aws_route53_zone" "new_int" {
10-19 18:15:03.711  level=error
10-19 18:15:03.965  level=error msg=failed to fetch Cluster: failed to generate asset "Cluster": failure applying terraform for "cluster" stage: failed to create cluster: failed to apply Terraform: exit status 1
10-19 18:15:03.965  level=error
10-19 18:15:03.965  level=error msg=Error: failed creating IAM Role (yunjiang-57c2s2-fmjqq-worker-role): RequestError: send request failed
10-19 18:15:03.965  level=error msg=caused by: Post "https://iam.us-iso-east-1.c2s.ic.gov/": Service Unavailable
10-19 18:15:03.965  level=error
10-19 18:15:03.965  level=error msg=  with module.iam.aws_iam_role.worker_role[0],
10-19 18:15:03.966  level=error msg=  on iam/main.tf line 13, in resource "aws_iam_role" "worker_role":
10-19 18:15:03.966  level=error msg=  13: resource "aws_iam_role" "worker_role" {
10-19 18:15:03.966  level=error
10-19 18:15:03.966  level=error
10-19 18:15:03.966  level=error msg=Error: failed creating IAM Role (yunjiang-57c2s2-fmjqq-master-role): RequestError: send request failed
10-19 18:15:03.966  level=error msg=caused by: Post "https://iam.us-iso-east-1.c2s.ic.gov/": Service Unavailable
10-19 18:15:03.966  level=error
10-19 18:15:03.966  level=error msg=  with module.masters.aws_iam_role.master_role[0],
10-19 18:15:03.966  level=error msg=  on master/main.tf line 18, in resource "aws_iam_role" "master_role":
10-19 18:15:03.966  level=error msg=  18: resource "aws_iam_role" "master_role" {
10-19 18:15:03.966  level=error
10-19 18:15:03.966  level=error
10-19 18:15:03.966  level=error msg=Error: error creating Route53 Hosted Zone: SerializationError: failed to unmarshal error message
10-19 18:15:03.966  level=error msg=	status code: 400, request id: 
10-19 18:15:03.966  level=error msg=caused by: UnmarshalError: failed to unmarshal error message
10-19 18:15:03.966  level=error msg=	00000000  3c 3f 78 6d 6c 20 76 65  72 73 69 6f 6e 3d 22 31  |<?xml version="1|
10-19 18:15:03.966  level=error msg=00000010  2e 30 22 20 65 6e 63 6f  64 69 6e 67 3d 22 55 54  |.0" encoding="UT|
10-19 18:15:03.966  level=error msg=00000020  46 2d 38 22 20 73 74 61  6e 64 61 6c 6f 6e 65 3d  |F-8" standalone=|
10-19 18:15:03.966  level=error msg=00000030  22 6e 6f 22 3f 3e 3c 52  65 73 70 6f 6e 73 65 3e  |"no"?><Response>|
10-19 18:15:03.966  level=error msg=00000040  3c 45 72 72 6f 72 73 3e  3c 45 72 72 6f 72 3e 3c  |<Errors><Error><|
10-19 18:15:03.966  level=error msg=00000050  43 6f 64 65 3e 55 6e 73  75 70 70 6f 72 74 65 64  |Code>Unsupported|
10-19 18:15:03.966  level=error msg=00000060  4f 70 65 72 61 74 69 6f  6e 3c 2f 43 6f 64 65 3e  |Operation</Code>|
10-19 18:15:03.966  level=error msg=00000070  3c 4d 65 73 73 61 67 65  3e 54 68 65 20 66 75 6e  |<Message>The fun|
10-19 18:15:03.966  level=error msg=00000080  63 74 69 6f 6e 61 6c 69  74 79 20 79 6f 75 20 72  |ctionality you r|
10-19 18:15:03.966  level=error msg=00000090  65 71 75 65 73 74 65 64  20 69 73 20 6e 6f 74 20  |equested is not |
10-19 18:15:03.966  level=error msg=000000a0  61 76 61 69 6c 61 62 6c  65 20 69 6e 20 74 68 69  |available in thi|
10-19 18:15:03.967  level=error msg=000000b0  73 20 72 65 67 69 6f 6e  2e 3c 2f 4d 65 73 73 61  |s region.</Messa|
10-19 18:15:03.967  level=error msg=000000c0  67 65 3e 3c 2f 45 72 72  6f 72 3e 3c 52 65 71 75  |ge></Error><Requ|
10-19 18:15:03.967  level=error msg=000000d0  65 73 74 49 44 3e 63 64  38 31 39 36 33 64 64 37  |estID>cd81963dd7|
10-19 18:15:03.967  level=error msg=000000e0  66 31 34 61 37 62 39 31  38 33 37 61 35 38 38 31  |f14a7b91837a5881|
10-19 18:15:03.967  level=error msg=000000f0  65 32 34 35 32 34 3c 2f  52 65 71 75 65 73 74 49  |e24524</RequestI|
10-19 18:15:03.967  level=error msg=00000100  44 3e 3c 2f 45 72 72 6f  72 73 3e 3c 2f 52 65 73  |D></Errors></Res|
10-19 18:15:03.967  level=error msg=00000110  70 6f 6e 73 65 3e                                 |ponse>|
10-19 18:15:03.967  level=error
10-19 18:15:03.967  level=error msg=caused by: unknown error response tag, {{ Response} []}
10-19 18:15:03.967  level=error
10-19 18:15:03.967  level=error msg=  with module.dns.aws_route53_zone.new_int[0],
10-19 18:15:03.967  level=error msg=  on route53/base.tf line 24, in resource "aws_route53_zone" "new_int":
10-19 18:15:03.967  level=error msg=  24: resource "aws_route53_zone" "new_int" {
10-19 18:15:03.967  level=error
10-19 18:15:03.967  level=error

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 20, 2022

This seems to be happening in a different terraform resource, but I wonder if it's related to #6475 and https://issues.redhat.com/browse/OCPBUGS-2324

@patrickdillon
Copy link
Contributor

/approve

@r4f4 you put a hold on this, is that still valid? seems ready to merge to me

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2023
@r4f4
Copy link
Contributor Author

r4f4 commented Jan 19, 2023

/approve

@r4f4 you put a hold on this, is that still valid? seems ready to merge to me

I hope I would've stated a reason for the hold, but I think I did it because we were still discussing if this needed an RFE or not.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6a6e213 and 2 for PR HEAD 876a11764decd9d4c290f8df64d7607fa3b723ec in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD db1b14f and 1 for PR HEAD 876a11764decd9d4c290f8df64d7607fa3b723ec in total

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 23, 2023

/retitle OCPBUGS-9435: new Aws secret regions support

@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 15, 2023
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-13636, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Add support for SC2S region (us-isob-east-1) and new TC2S region (us-iso-west-1).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor Author

r4f4 commented May 15, 2023

I have broken out the CNAME -> Alias change to its own PR: #7184

@r4f4
Copy link
Contributor Author

r4f4 commented May 15, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-13636, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@r4f4
Copy link
Contributor Author

r4f4 commented May 15, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 15, 2023
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-13636, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gpei May 15, 2023 12:54
@gpei
Copy link
Contributor

gpei commented May 17, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@gpei: This pull request references Jira Issue OCPBUGS-13636, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (yunjiang@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gpei
Copy link
Contributor

gpei commented May 18, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@gpei: This pull request references Jira Issue OCPBUGS-13636, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (yunjiang@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 64e4797 and 2 for PR HEAD 6012c3c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 876a11764decd9d4c290f8df64d7607fa3b723ec link false /test e2e-aws-single-node
ci/prow/e2e-aws-ovn-single-node 6012c3c link false /test e2e-aws-ovn-single-node
ci/prow/okd-e2e-aws-ovn 6012c3c link false /test okd-e2e-aws-ovn
ci/prow/e2e-aws-ovn-fips 6012c3c link false /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-imdsv2 6012c3c link false /test e2e-aws-ovn-imdsv2
ci/prow/e2e-aws-ovn-shared-vpc 6012c3c link false /test e2e-aws-ovn-shared-vpc
ci/prow/okd-scos-e2e-aws-ovn 6012c3c link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 58bbafb and 1 for PR HEAD 6012c3c in total

@openshift-merge-robot openshift-merge-robot merged commit a4e933c into openshift:master Jun 21, 2023
@openshift-ci-robot
Copy link
Contributor

@r4f4: Jira Issue OCPBUGS-13636: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13636 has been moved to the MODIFIED state.

Details

In response to this:

Add support for SC2S region (us-isob-east-1) and new TC2S region (us-iso-west-1).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Jun 21, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot

@r4f4: new pull request created: #7264

Details

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.