pkg/asset/installconfig/basedomain: Document cluster-name subdomains#630
Conversation
Brian says [1]: The third time I had to abort was when prompted for base domain followed by cluster name (I included my cluster name in my base domain because I'm using a well structure name server delegation structure). And I've seen a number of other cases where folks suggest including the cluster name again in the base domain. Sometimes you might need to do that (e.g. if you cannot create subdomains without the additional namespacing). But in most cases, including the cluster name in the base domain is redundant. [1]: openshift#627 (comment)
openshift-ci-robot
added
size/XS
|
Not sure what's happening here, why do people assume cluster name to be part of the base domain? Even if they do we need the cluster name to create other dns entries... |
|
At least @vrutkovs has done the same thing. I think a bit of extra docs around this would help. Maybe @brianredbeard or @vrutkovs can speak to whether this change would have helped them? |
|
I remember doing exactly that before etcd discovery landed, so some clarification won't hurt |
|
I think we should improve the info, but just curious as to why |
Domains used by the installed cluster will all be subdomains of the base domain. Those subdomains will all include the cluster name.
but maybe the wording could be improved? Suggestions? |
|
fine for now. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
deleted the
improve-docs-for-cluster-name-base-domain-interaction
branch
5 participants
@brianredbeard says:
And I've seen a number of other cases where folks suggest including the cluster name again in the base domain. Sometimes you might need to do that (e.g. if you cannot create subdomains without the additional namespacing). But in most cases, including the cluster name in the base domain is redundant.