AGENT-284: Allow user to choose platform type#6438
Merged
openshift-merge-robot merged 7 commits intoopenshift:masterfrom Oct 14, 2022
Merged
Conversation
pawanpinjarkar
changed the title
Contributor
Author
|
/uncc @dhellmann @patrickdillon |
openshift-ci
bot
requested review from
andfasano and
zaneb
and removed request for
dhellmann and
patrickdillon
Member
|
Would be good to validate that for SNO specifically, only platform: none is allowed. Pawan is opening another Jira ticket to follow up with that. |
Contributor
Author
|
Opened https://issues.redhat.com/browse/AGENT-369 for additional validation for the SNO cluster |
Member
|
/retest |
Contributor
Author
|
/assign @patrickdillon Please approve |
Member
|
/retest |
openshift-merge-robot
added
the
needs-rebase
pawanpinjarkar
force-pushed
the
allow-user-to-choose-platform-type
branch
from
da0017a to
32cddef
Compare
openshift-merge-robot
removed
the
needs-rebase
bfournie
reviewed
Oct 3, 2022
Member
|
/lgtm |
openshift-ci
bot
added
lgtm
pawanpinjarkar
force-pushed
the
allow-user-to-choose-platform-type
branch
from
3a33ba3 to
8b71ead
Compare
pawanpinjarkar
requested review from
bfournie and
zaneb
and removed request for
andfasano,
bfournie and
zaneb
pawanpinjarkar
force-pushed
the
allow-user-to-choose-platform-type
branch
from
8b71ead to
9387784
Compare
openshift-merge-robot
removed
the
needs-rebase
Contributor
Author
|
/retest-required |
openshift-merge-robot
added
the
needs-rebase
Update to the assisted-service at commit a40422bdea617f16cbdb724d53619ca74773be45. This repo now contains multiple go modules, so we have to add overrides for the internal references to the api and models modules.
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
pawanpinjarkar
force-pushed
the
allow-user-to-choose-platform-type
branch
from
5bd1168 to
49a1de2
Compare
openshift-merge-robot
removed
the
needs-rebase
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
pawanpinjarkar
force-pushed
the
allow-user-to-choose-platform-type
branch
from
c6d939f to
096f09d
Compare
Member
|
/lgtm |
Contributor
Contributor
Author
|
/retest-required |
Contributor
Contributor
Contributor
|
/hold Revision 096f09d was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
Member
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Contributor
Contributor
Author
|
/retest |
Contributor
|
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reads the platform name from
install-config.yamland sets the appropriate and supported platform in theAgentClusterInstall.Spec.PlatformType. Assisted service uses theAgentClusterInstall.Spec.PlatformTypeas cluster params to create the cluster. When using the ZTP way, users can directly provide the supported platforms inAgentClusterInstall.Spec.PlatformType.We already have a validation to throw an error if users provide unsupported platforms for the agent installer in the install-config.yaml. This PR also adds a similar validation when unsupported
PlatformTypeis provided in the AgentClusterInstall.Signed-off-by: Pawan Pinjarkar ppinjark@redhat.com
Signed-off-by: Zane Bitter zaneb@redhat.com