Skip to content

Bug 2117537: validation rule for invalid rendezvousIP in AgentConfig#6474

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
andfasano:agent-fix-rendezvousIP
Oct 18, 2022
Merged

Bug 2117537: validation rule for invalid rendezvousIP in AgentConfig#6474
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
andfasano:agent-fix-rendezvousIP

Conversation

@andfasano
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from bfournie and lranjbar October 11, 2022 08:33
@andfasano andfasano changed the title BZ 2117537: validations rules for missing/invalid rendezvousIP in AgentConfig OCPBUGSM-47889: validations rules for missing/invalid rendezvousIP in AgentConfig Oct 11, 2022
@andfasano andfasano force-pushed the agent-fix-rendezvousIP branch from 307e1aa to f95cdc5 Compare October 11, 2022 08:38
@andfasano andfasano changed the title OCPBUGSM-47889: validations rules for missing/invalid rendezvousIP in AgentConfig Bug 2117537: validations rule for invalid rendezvousIP in AgentConfig Oct 11, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

@andfasano: This pull request references Bugzilla bug 2117537, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2117537: validations rule for invalid rendezvousIP in AgentConfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano andfasano changed the title Bug 2117537: validations rule for invalid rendezvousIP in AgentConfig Bug 2117537: validation rule for invalid rendezvousIP in AgentConfig Oct 11, 2022
@andfasano
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

@andfasano: This pull request references Bugzilla bug 2117537, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mhanss

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from mhanss October 11, 2022 08:46
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2022
@mhanss
Copy link
Contributor

mhanss commented Oct 11, 2022

Bug has been verified using this PR, it's working as expected.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 11, 2022
@bfournie
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 85c8d56 and 2 for PR HEAD f95cdc5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 045b952 and 1 for PR HEAD f95cdc5 in total

@andfasano
Copy link
Contributor Author

/test e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 53766db into openshift:master Oct 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

@andfasano: All pull requests linked via external trackers have merged:

Bugzilla bug 2117537 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2117537: validation rule for invalid rendezvousIP in AgentConfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants