OCPBUGS-2837: Reduce debug logs in agent wait-for commands#6520
OCPBUGS-2837: Reduce debug logs in agent wait-for commands#6520openshift-merge-robot merged 3 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-bug
|
@zaneb: This pull request references Jira Issue OCPBUGS-2837, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lranjbar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
pkg/agent/kube.go
Outdated
There was a problem hiding this comment.
| if err != nil && !k8serrors.IsNotFound(err) { | |
| if !k8serrors.IsNotFound(err) { |
nit: IsNotFound should return false if error is nil
There was a problem hiding this comment.
It should, but we want this block to not execute if the error is nil.
zaneb
force-pushed
the
reduce-debug-logs
branch
from
2ed7d99 to
7c64cea
Compare
openshift-merge-robot
added
the
needs-rebase
The IPI wait-for install-complete command uses a watch on the clusterversion object to log the status when it changes. While the agent wait-for install-complete command uses similar logging code, it gets the status by polling rather than using a watch. This results in many more identical debug messages. To emulate the behaviour of IPI, only print a debug message when the clusterversion object has changed.
If we get an empty string, don't try to parse it as JSON. Avoids this message: level=info msg=cluster host validations failed: unable to verify validations: unexpected end of JSON input
Consistently use the following terms: - Agent Rest API - Bootstrap Kube API We don't use the term "Node Zero" in any user-facing places, and the kube API that we're waiting for is generally the bootkube API on the bootstrap, not the actual cluster API.
zaneb
force-pushed
the
reduce-debug-logs
branch
from
7c64cea to
f9f31d3
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
|
@zaneb: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@zaneb: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-2837 has been moved to the MODIFIED state. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
No description provided.