Skip to content

openstack: Revert Gophercloud workaround#6663

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:bump_gophercloud
Jan 7, 2023
Merged

openstack: Revert Gophercloud workaround#6663
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:bump_gophercloud

Conversation

@pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Dec 5, 2022 •
edited
Loading

With the bump to Gophercloud v1.1.1, the library should be able to handle HTTP status 204 responses without content-type without erroring. The workaround that was in place to force contentful responses can then be removed.

Follows up on #6615

@openshift-ci openshift-ci bot requested review from jhixson74 and mandre December 5, 2022 10:16
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Dec 5, 2022

/assign @barbacbd

mandre
mandre reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pierreprinetti.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
mandre
mandre reviewed Dec 6, 2022
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restoring my LGTM after the rebase.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Dec 6, 2022

/cc sadasu

@openshift-ci openshift-ci bot requested a review from sadasu December 6, 2022 12:37
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Dec 6, 2022

/retest-required

1 similar comment
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Dec 6, 2022

/retest-required

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Dec 7, 2022

rebased. CC @mandre

mandre
mandre reviewed Dec 7, 2022
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mandre
Copy link
Member

mandre commented Dec 7, 2022

/hold
We'll want v1.1.1 instead.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2022
@pierreprinetti pierreprinetti force-pushed the bump_gophercloud branch 2 times, most recently from da0dd9e to 07cce16 Compare December 7, 2022 14:29
mandre
mandre reviewed Dec 7, 2022
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 7, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Dec 7, 2022

/retest

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Dec 22, 2022

@mandre

e2e-azure-ovn is apparently broken since Dec 10, can we consider overriding it since it should not be impacted by this change?

@patrickdillon has a more definitive solution here: openshift/release#34883

@r4f4
Copy link
Contributor

r4f4 commented Dec 22, 2022

/override ci/prow/e2e-azure-ovn
Install succeeded and not affected by the changes in this PR.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2022

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn

Details

In response to this:

/override ci/prow/e2e-azure-ovn
Install succeeded and not affected by the changes in this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 22, 2022

/retest-required

Remaining retests: 0 against base HEAD 73b7d07 and 0 for PR HEAD a6d7a4b in total

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Dec 22, 2022

/test e2e-gcp-ovn

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 23, 2022

/hold

Revision a6d7a4b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2022
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Dec 23, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 23, 2022

/retest-required

Remaining retests: 0 against base HEAD 52b495c and 2 for PR HEAD a6d7a4b in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 23, 2022

/retest-required

Remaining retests: 0 against base HEAD 1d972a8 and 1 for PR HEAD a6d7a4b in total

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Dec 29, 2022

/retest-required

1 similar comment
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Jan 2, 2023

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 3, 2023

/retest-required

Remaining retests: 0 against base HEAD 9de173a and 0 for PR HEAD a6d7a4b in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 3, 2023

/hold

Revision a6d7a4b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2023
@mandre
Copy link
Member

mandre commented Jan 4, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 4, 2023

/retest-required

Remaining retests: 0 against base HEAD ce13271 and 2 for PR HEAD a6d7a4b in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 4, 2023

/retest-required

Remaining retests: 0 against base HEAD 23ed14b and 1 for PR HEAD a6d7a4b in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 5, 2023

/retest-required

Remaining retests: 0 against base HEAD 565cbf8 and 0 for PR HEAD a6d7a4b in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 5, 2023

/hold

Revision a6d7a4b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2023 •
edited
Loading

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-disruptive a6d7a4b link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-libvirt a6d7a4b link false /test e2e-libvirt
ci/prow/e2e-metal-assisted a6d7a4b link false /test e2e-metal-assisted
ci/prow/e2e-openstack-proxy a6d7a4b link false /test e2e-openstack-proxy
ci/prow/e2e-openstack-kuryr a6d7a4b link false /test e2e-openstack-kuryr
ci/prow/e2e-openstack-sdn-parallel a6d7a4b link false /test e2e-openstack-sdn-parallel
ci/prow/okd-e2e-aws-ovn-upgrade a6d7a4b link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-ibmcloud-ovn a6d7a4b link false /test e2e-ibmcloud-ovn
ci/prow/okd-scos-e2e-aws-upgrade a6d7a4b link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-scos-e2e-aws-ovn a6d7a4b link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade a6d7a4b link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-sdn a6d7a4b link false /test e2e-metal-ipi-sdn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Member

mandre commented Jan 6, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2023

/retest-required

Remaining retests: 0 against base HEAD 9110f2d and 2 for PR HEAD a6d7a4b in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2023

/retest-required

Remaining retests: 0 against base HEAD 35f1aca and 1 for PR HEAD a6d7a4b in total

@openshift-merge-robot openshift-merge-robot merged commit fee01a8 into openshift:master Jan 7, 2023
@pierreprinetti pierreprinetti deleted the bump_gophercloud branch January 7, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@sadasu sadasu Awaiting requested review from sadasu

1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

@barbacbd barbacbd

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pierreprinetti @mandre @patrickdillon @openshift-ci-robot @r4f4 @barbacbd @openshift-merge-robot