OpenStack: Dual stack support with BYON by MaysaMacedo · Pull Request #6797 · openshift/installer

MaysaMacedo · 2023-01-24T15:00:36Z

This commit adds dual stack support with bring your own network
for OpenStack platform. The new ControlPlanePort field accepts IPv4/IPv6
subnets and the network in the install config, while the machinesSubnet
that only supports IPv4 Subnets is deprecated.

Partially implements: openshift/enhancements#1365

openshift-ci · 2023-01-24T15:00:48Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

data/data/install.openshift.io_installconfigs.yaml

MaysaMacedo · 2023-05-18T21:51:27Z

/retest

sadasu · 2023-07-11T13:07:27Z

data/data/install.openshift.io_installconfigs.yaml

Is the network required here?

No, because machinesSubnet only contains info about the subnet and that would be the only info added to controlPlanePort during conversion.

pkg/asset/installconfig/openstack/validation/cloudinfo.go

data/data/install.openshift.io_installconfigs.yaml

pkg/asset/installconfig/openstack/validation/platform.go

This commit adds dual stack support with bring your own network for OpenStack platform. The new ControlPlanePort field accepts IPv4/IPv6 subnets and the network in the install config, while the machinesSubnet only supports IPv4 Subnets and is deprecated.

sadasu · 2023-07-11T19:14:47Z

pkg/asset/installconfig/openstack/validation/platform.go

 }

-// validateMachinesSubnet validates the machines subnet and enforces proper byo subnet usage and returns a list of all validation errors
-func validateMachinesSubnet(p *openstack.Platform, n *types.Networking, ci *CloudInfo, fldPath *field.Path) (allErrs field.ErrorList) {


This validation function is being removed because the machineSubnets config would be converted to controlPlanePort's network config before it is validated (i.e when the deprecated config is provided by the user and not the new config)?

Yes.
The conversion happens when loading the install-config, which happens before the platform validation.

sadasu · 2023-07-12T00:15:15Z

/approve

openshift-ci · 2023-07-12T00:15:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sadasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dulek · 2023-07-12T09:28:44Z

/lgtm

openshift-ci-robot · 2023-07-12T09:58:10Z

/retest-required

Remaining retests: 0 against base HEAD d3c563d and 2 for PR HEAD 6df11aa in total

MaysaMacedo · 2023-07-12T23:19:36Z

/retest-required

MaysaMacedo · 2023-07-13T11:57:43Z

/retest

MaysaMacedo · 2023-07-14T12:40:15Z

/retest

openshift-ci-robot · 2023-07-14T13:18:23Z

/retest-required

Remaining retests: 0 against base HEAD 169ffbf and 1 for PR HEAD 6df11aa in total

MaysaMacedo · 2023-07-14T17:34:42Z

/test okd-images
/test okd-scos-images

openshift-ci-robot · 2023-07-15T05:18:42Z

/retest-required

Remaining retests: 0 against base HEAD 12030a6 and 0 for PR HEAD 6df11aa in total

openshift-ci-robot · 2023-07-15T10:18:35Z

/hold

Revision 6df11aa was retested 3 times: holding

MaysaMacedo · 2023-07-15T20:06:30Z

/test okd-scos-images

MaysaMacedo · 2023-07-15T20:06:46Z

/hold cancel

openshift-ci-robot · 2023-07-15T22:18:17Z

/retest-required

Remaining retests: 0 against base HEAD ec459b1 and 2 for PR HEAD 6df11aa in total

openshift-ci · 2023-07-16T05:42:55Z

@MaysaMacedo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-public-subnets	0b8853112e4380cdeac7ba08fde6a441a1c13289	link	false	`/test e2e-aws-ovn-public-subnets`
ci/prow/okd-scos-e2e-aws-upgrade	386c2844901e850c4f3f163da552d53b83d78e5f	link	false	`/test okd-scos-e2e-aws-upgrade`
ci/prow/e2e-agent-ha-dualstack	`6df11aa`	link	false	`/test e2e-agent-ha-dualstack`
ci/prow/okd-scos-e2e-aws-ovn	`6df11aa`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/okd-e2e-aws-ovn-upgrade	`6df11aa`	link	false	`/test okd-e2e-aws-ovn-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-07-16T06:18:20Z

/retest-required

Remaining retests: 0 against base HEAD 79a013e and 1 for PR HEAD 6df11aa in total

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2023

EmilienM mentioned this pull request Jan 24, 2023

Add OpenStack Failure Domains openshift/enhancements#1319

Closed

EmilienM reviewed Jan 24, 2023

View reviewed changes

data/data/install.openshift.io_installconfigs.yaml Outdated Show resolved Hide resolved

MaysaMacedo force-pushed the dualstack-support branch from 10f072a to 1bf3a3c Compare February 23, 2023 18:30

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2023

MaysaMacedo force-pushed the dualstack-support branch from 1bf3a3c to c11c5c1 Compare February 23, 2023 20:30

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2023

MaysaMacedo force-pushed the dualstack-support branch 2 times, most recently from 8f53871 to 48035ce Compare March 10, 2023 12:38

MaysaMacedo marked this pull request as ready for review March 10, 2023 12:39

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2023

openshift-ci bot requested review from EmilienM and dulek March 10, 2023 12:41

MaysaMacedo force-pushed the dualstack-support branch 2 times, most recently from 37ed291 to 0b88531 Compare March 10, 2023 13:43

MaysaMacedo force-pushed the dualstack-support branch 5 times, most recently from 386c284 to e2fb040 Compare April 18, 2023 16:17

MaysaMacedo force-pushed the dualstack-support branch 3 times, most recently from 12a7fcf to 7f99510 Compare April 26, 2023 11:02

MaysaMacedo mentioned this pull request May 3, 2023

OpenStack: support user provided dual-stack api and ingress Port #7133

Merged

MaysaMacedo force-pushed the dualstack-support branch 2 times, most recently from dc62708 to 6bd7d53 Compare May 17, 2023 14:30

MaysaMacedo force-pushed the dualstack-support branch 2 times, most recently from e2593b5 to 737100f Compare May 19, 2023 12:46

sadasu reviewed Jul 11, 2023

View reviewed changes

pkg/asset/installconfig/openstack/validation/cloudinfo.go Outdated Show resolved Hide resolved

sadasu reviewed Jul 11, 2023

View reviewed changes

data/data/install.openshift.io_installconfigs.yaml Outdated Show resolved Hide resolved

sadasu reviewed Jul 11, 2023

View reviewed changes

pkg/asset/installconfig/openstack/validation/platform.go Outdated Show resolved Hide resolved

MaysaMacedo force-pushed the dualstack-support branch from 509f23a to 5b7586e Compare July 11, 2023 14:19

MaysaMacedo force-pushed the dualstack-support branch from 5b7586e to 6df11aa Compare July 11, 2023 17:36

sadasu reviewed Jul 11, 2023

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2023

openshift-merge-robot merged commit c2d7db9 into openshift:master Jul 16, 2023

MaysaMacedo deleted the dualstack-support branch July 16, 2023 21:02

Conversation

MaysaMacedo commented Jan 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jan 24, 2023

Uh oh!

Uh oh!

MaysaMacedo commented May 18, 2023

Uh oh!

sadasu Jul 11, 2023

Choose a reason for hiding this comment

Uh oh!

MaysaMacedo Jul 11, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sadasu Jul 11, 2023

Choose a reason for hiding this comment

Uh oh!

MaysaMacedo Jul 11, 2023

Choose a reason for hiding this comment

Uh oh!

sadasu commented Jul 12, 2023

Uh oh!

openshift-ci bot commented Jul 12, 2023

Uh oh!

dulek commented Jul 12, 2023

Uh oh!

openshift-ci-robot commented Jul 12, 2023

Uh oh!

MaysaMacedo commented Jul 12, 2023

Uh oh!

MaysaMacedo commented Jul 13, 2023

Uh oh!

MaysaMacedo commented Jul 14, 2023

Uh oh!

openshift-ci-robot commented Jul 14, 2023

Uh oh!

MaysaMacedo commented Jul 14, 2023

Uh oh!

openshift-ci-robot commented Jul 15, 2023

Uh oh!

openshift-ci-robot commented Jul 15, 2023

Uh oh!

MaysaMacedo commented Jul 15, 2023

Uh oh!

MaysaMacedo commented Jul 15, 2023

Uh oh!

openshift-ci-robot commented Jul 15, 2023

Uh oh!

openshift-ci bot commented Jul 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

MaysaMacedo commented Jan 24, 2023 •

edited

Loading

openshift-ci bot commented Jul 16, 2023 •

edited

Loading