OpenStack: support user provided dual-stack api and ingress Port#7133
Conversation
MaysaMacedo
force-pushed
the
include-provided-port
branch
3 times, most recently
from
a5cf3d3 to
ba4a314
Compare
MaysaMacedo
changed the title
|
/retest |
|
I will add validation that requires the API VIPs being in one unique Port and the same for Ingress on the BYON PR because I want to use the Subnets ID when querying for the Port. |
|
/test e2e-openstack-proxy |
2 similar comments
|
/test e2e-openstack-proxy |
|
/test e2e-openstack-proxy |
|
@mandre @pierreprinetti I'll like your opinion as well. See my comments. |
|
/lgtm |
MaysaMacedo
force-pushed
the
include-provided-port
branch
from
ba4a314 to
65f609d
Compare
MaysaMacedo
force-pushed
the
include-provided-port
branch
2 times, most recently
from
dcdd1bc to
cd4a223
Compare
|
/test e2e-openstack-proxy |
|
@EmilienM @mdbooth @pierreprinetti |
|
/lgtm |
There was a problem hiding this comment.
These are called "ports" but only hold a single port?
There was a problem hiding this comment.
I tried to follow the same logic of the example from terraform https://registry.terraform.io/providers/terraform-provider-openstack/openstack/latest/docs/data-sources/networking_port_ids_v2.
Note this is filtering Ports based on the attributes of fixed_ip and network and returns a list.
MaysaMacedo
force-pushed
the
include-provided-port
branch
from
cd4a223 to
9aa9040
Compare
|
/lgtm |
When using dual-stack installations the user needs to pre-create the api and ingress port given OpenStack does not allow direct assignment of addresses when using slaac/stateless, consequently the installer can't create those. This commit adds support to tag those Ports, assign security groups to them, attach the Floating IP when needed and allow clean up of resources.
MaysaMacedo
force-pushed
the
include-provided-port
branch
from
9aa9040 to
229feb0
Compare
|
/lgtm |
|
@EmilienM could you take another look for the |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Presubmit failures don't look great since they're installer failures. In the feature queue spreadsheet there's 4 PR's listed - are they all co-dependent? |
|
/retest @stbenjam No, they're not dependent on one another. |
|
@MaysaMacedo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@stbenjam o/ all the tests passed. Can you take another look? Thanks |
|
/label jira/valid-bug |
openshift-ci
bot
added
the
jira/valid-bug
8 participants
When using dual-stack installations the user needs to pre-create the api and ingress port given OpenStack does not allow direct assignment of addresses when using slaac/stateless, consequently the installer can't create those. This commit adds support to tag those Ports, assign security groups to them, attach the Floating IP when needed and allow clean up of resources.
Partially implements: openshift/enhancements#1365