scripts/maintenance/clean-aws.sh: Skip $tag_file for unset --tag-file#76
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jul 27, 2018
Merged
Conversation
d541760 (scripts/maintenance/*-aws: Drop --workspace-dir, 2018-07-08, openshift#34) cleaned up some related handling, but missed this. Before this commit, an unset --tag-file would have resulted in a useless $tag_file creation which was never written to, and the "Deleting resources with the following tags:" line wouldn't actually print the actual tag.json content.
Member
Author
|
The e2e-aws errors were more EIP exhaustion: I've got a script cleaning out leaked EIPs now, so we should be clear on that front. /retest |
Contributor
|
/lgtm |
Member
Author
|
The e2e-aws errors were: Perhaps the effect of overeager resource leak protection (although I don't see those IDs in the logs of my leak-pruning runs). Anyway, give it another shot: /retest |
Member
Author
|
Got: despite the same test passing just before. Weird. /retest |
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Feb 10, 2021
Add a second-level image cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d541760 (#34) cleaned up some related handling, but missed this. Before this commit, an unset
--tag-filewould have resulted in a useless$tag_filecreation which was never written to, and the "Deleting resources with the following tags:" line wouldn't actually print the actualtag.jsoncontent.