SPLAT-1208: replace UPI terraform with powercli#7699
SPLAT-1208: replace UPI terraform with powercli#7699openshift-merge-bot[bot] merged 9 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vr4manta: This pull request references SPLAT-1208 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
upi/vsphere/variables.ps1
Outdated
There was a problem hiding this comment.
are these used in CI? or is it over-written?
There was a problem hiding this comment.
This file is going to be renamed .example. The CI does pass these in.
upi/vsphere/variables.ps1
Outdated
There was a problem hiding this comment.
I wonder if we could just get the distributed_virtual_switch_uuid instead of defining the uuid statically?
There was a problem hiding this comment.
I am not using these. I'll remove it. Good catch.
|
FYI @sgaoshang @WenXinWei |
|
/test e2e-vsphere-upi |
|
/test all |
|
@vr4manta: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-vsphere-upi-zones |
2 similar comments
|
/test e2e-vsphere-upi-zones |
|
/test e2e-vsphere-upi-zones |
images/installer/Dockerfile.upi.ci
Outdated
There was a problem hiding this comment.
what's that mkdir for? I am assuming its for powercli but wouldn't that be before the Import-Module?
There was a problem hiding this comment.
That directory is where config settings get put when we do stuff such as:
Set-PowerCLIConfiguration -InvalidCertificateAction:Ignore -Confirm:$false
I am not sure the order matters, but as I hit the issue testing the image, I just added to end of this command list to keep in same layer.
upi/vsphere/upi-destroy.ps1
Outdated
There was a problem hiding this comment.
Maybe this is a follow up PR but we have the certificates available in the ipi destroy.
There was a problem hiding this comment.
Hmm, I never did look into making sure pwsh could see the certs. I did this so we can make progress when install was not liking talking to vcenter. I can make a card for this to add next if you are ok with that.
vr4manta
force-pushed
the
SPLAT-1208
branch
2 times, most recently
from
efc6719 to
a6845ff
Compare
|
/test e2e-vsphere-upi e2e-vsphere-ovn |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
/assign @patrickdillon @r4f4 |
r4f4
left a comment
r4f4
left a comment
There was a problem hiding this comment.
Maybe we want to separate the 2 configs: upi/vsphere/terraform and upi/vsphere/powercli?
images/installer/Dockerfile.upi.ci
Outdated
There was a problem hiding this comment.
| RUN curl https://packages.microsoft.com/config/rhel/8/prod.repo | tee /etc/yum.repos.d/microsoft.repo | |
| RUN curl https://packages.microsoft.com/config/rhel/8/prod.repo -o /etc/yum.repos.d/microsoft.repo |
There was a problem hiding this comment.
I'd prefer if we steered away from curling deps all the time and instead used an existing container image, the same way we get govc, for example.
There was a problem hiding this comment.
I'll try to clean that up. Thanks for the feedback.
|
/hold Revision cbe9796 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold Revision cbe9796 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
@r4f4 can we get an override on the azure upi? |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/override ci/prow/e2e-azure-ovn-upi |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold Revision cbe9796 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
@vr4manta: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/override ci/prow/e2e-azure-ovn-upi |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-azure-ovn-upi |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404201710.p0.g9938156.assembly.stream.el8 for distgit ose-installer-altinfra. |
6 participants
This PR is creating new PowerShell scripts to perform the vsphere infrastructure creation. These new scripts will replace the existing Terraform scripts; however, we'll keep the terraform files around for others to still use as an example if they need to for their projects.