Skip to content

SPLAT-1277: unrevert PR 7418; implement vSphere control plane machinesets#7780

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
rvanderp3:revert-7708
Nov 30, 2023
Merged

SPLAT-1277: unrevert PR 7418; implement vSphere control plane machinesets#7780
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
rvanderp3:revert-7708

Conversation

@rvanderp3
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 28, 2023

@rvanderp3: This pull request references CORS-2726 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.15." or "openshift-4.15.", but it targets "openshift-4.16" instead.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3
Copy link
Contributor Author

/test e2e-vsphere-ovn
/test e2e-vsphere-zones-techpreview

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rvanderp3
Copy link
Contributor Author

/test all

@rvanderp3
Copy link
Contributor Author

/retest-required

@rvanderp3
Copy link
Contributor Author

/test tf-fmt

@rvanderp3 rvanderp3 changed the title CORS-2726: unrevert PR 7418; implement vSphere control plane machinesets SPLAT-1277: unrevert PR 7418; implement vSphere control plane machinesets Nov 28, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 28, 2023

@rvanderp3: This pull request references SPLAT-1277 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3 rvanderp3 marked this pull request as ready for review November 28, 2023 21:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@rvanderp3
Copy link
Contributor Author

For vSphere zonal jobs, the storage operator is failing due to https://issues.redhat.com/browse/OCPBUGS-23970 and is being addressed in openshift/vmware-vsphere-csi-driver-operator#192. Confirmed that the control plane machineset operator is reconciling the control plane machinset manifest from the installer.

@rvanderp3
Copy link
Contributor Author

/assign @patrickdillon

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@rvanderp3
Copy link
Contributor Author

/test e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 00dc905 and 2 for PR HEAD e0151ed in total

@rvanderp3
Copy link
Contributor Author

We are seeing a high flake rate on e2e-vsphere-ovn for presubmits and the issue is consistent outside of this PR as well. Confirmed that the control plane machineset is not deployed unless the tech preview feature set is enabled.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 153837a and 1 for PR HEAD e0151ed in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-zones e0151ed link false /test e2e-vsphere-zones
ci/prow/e2e-vsphere-zones-techpreview e0151ed link false /test e2e-vsphere-zones-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvanderp3
Copy link
Contributor Author

/test e2e-vsphere-ovn

@openshift-merge-bot openshift-merge-bot bot merged commit 1c0d4dc into openshift:master Nov 30, 2023
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.15.0-202311301049.p0.g1c0d4dc.assembly.stream for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants