CORS-3470: capi/aws: add custom endpoint support.

[r4f4]

The service endpoints need to be passed to the CAPA controller via the --service-endpoints argument.

[openshift-ci-robot]

@r4f4: This pull request references CORS-3470 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

The service endpoints need to be passed to the CAPA controller via the --service-endpoints argument.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[r4f4]

I don't see any CI jobs I can trigger to test this. The steps/chains in release that set up custom endpoints are cucushift-based.

[mtulio]

/test ?

[openshift-ci]

@mtulio: The following commands are available to trigger required jobs:

• /test agent-integration-tests
• /test altinfra-images
• /test altinfra-openstack-capi-manifests
• /test altinfra-periodics-images
• /test aro-unit
• /test e2e-agent-compact-ipv4
• /test e2e-aws-ovn
• /test e2e-aws-ovn-edge-zones-manifest-validation
• /test e2e-aws-ovn-upi
• /test e2e-azure-ovn
• /test e2e-azure-ovn-upi
• /test e2e-gcp-ovn
• /test e2e-gcp-ovn-upi
• /test e2e-metal-ipi-ovn-ipv6
• /test e2e-openstack-ovn
• /test e2e-vsphere-ovn
• /test e2e-vsphere-upi
• /test gofmt
• /test golint
• /test govet
• /test images
• /test okd-images
• /test okd-scos-images
• /test okd-unit
• /test okd-verify-codegen
• /test openstack-manifests
• /test shellcheck
• /test terraform-images
• /test terraform-verify-vendor
• /test tf-lint
• /test unit
• /test verify-codegen
• /test verify-vendor
• /test yaml-lint

The following commands are available to trigger optional jobs:

• /test altinfra-e2e-aws-custom-security-groups
• /test altinfra-e2e-aws-ovn
• /test altinfra-e2e-aws-ovn-fips
• /test altinfra-e2e-aws-ovn-imdsv2
• /test altinfra-e2e-aws-ovn-localzones
• /test altinfra-e2e-aws-ovn-proxy
• /test altinfra-e2e-aws-ovn-public-ipv4-pool
• /test altinfra-e2e-aws-ovn-shared-vpc
• /test altinfra-e2e-aws-ovn-shared-vpc-local-zones
• /test altinfra-e2e-aws-ovn-shared-vpc-wavelength-zones
• /test altinfra-e2e-aws-ovn-single-node
• /test altinfra-e2e-aws-ovn-wavelengthzones
• /test altinfra-e2e-azure-capi-ovn
• /test altinfra-e2e-gcp-capi-ovn
• /test altinfra-e2e-gcp-ovn-byo-network-capi
• /test altinfra-e2e-gcp-ovn-secureboot-capi
• /test altinfra-e2e-gcp-ovn-xpn-capi
• /test altinfra-e2e-ibmcloud-capi-ovn
• /test altinfra-e2e-nutanix-capi-ovn
• /test altinfra-e2e-openstack-capi-ccpmso
• /test altinfra-e2e-openstack-capi-ccpmso-zone
• /test altinfra-e2e-openstack-capi-dualstack
• /test altinfra-e2e-openstack-capi-dualstack-upi
• /test altinfra-e2e-openstack-capi-dualstack-v6primary
• /test altinfra-e2e-openstack-capi-externallb
• /test altinfra-e2e-openstack-capi-nfv-intel
• /test altinfra-e2e-openstack-capi-ovn
• /test altinfra-e2e-openstack-capi-proxy
• /test altinfra-e2e-powervs-capi-ovn
• /test altinfra-e2e-vsphere-capi-ovn
• /test altinfra-e2e-vsphere-capi-static-ovn
• /test altinfra-e2e-vsphere-capi-zones
• /test azure-ovn-marketplace-images
• /test e2e-agent-compact-ipv4-appliance
• /test e2e-agent-compact-ipv4-appliance-diskimage
• /test e2e-agent-compact-ipv4-none-platform
• /test e2e-agent-ha-dualstack
• /test e2e-agent-sno-ipv4-pxe
• /test e2e-agent-sno-ipv6
• /test e2e-aws-custom-security-groups
• /test e2e-aws-overlay-mtu-ovn-1200
• /test e2e-aws-ovn-edge-zones
• /test e2e-aws-ovn-fips
• /test e2e-aws-ovn-imdsv2
• /test e2e-aws-ovn-proxy
• /test e2e-aws-ovn-public-subnets
• /test e2e-aws-ovn-shared-vpc
• /test e2e-aws-ovn-shared-vpc-edge-zones
• /test e2e-aws-ovn-single-node
• /test e2e-aws-ovn-upgrade
• /test e2e-aws-ovn-workers-rhel8
• /test e2e-aws-upi-proxy
• /test e2e-azure-ovn-resourcegroup
• /test e2e-azure-ovn-shared-vpc
• /test e2e-azurestack
• /test e2e-azurestack-upi
• /test e2e-crc
• /test e2e-gcp-ovn-shared-vpc
• /test e2e-gcp-ovn-xpn
• /test e2e-gcp-secureboot
• /test e2e-gcp-upgrade
• /test e2e-gcp-upi-xpn
• /test e2e-ibmcloud-ovn
• /test e2e-metal-assisted
• /test e2e-metal-ipi-ovn
• /test e2e-metal-ipi-ovn-dualstack
• /test e2e-metal-ipi-ovn-swapped-hosts
• /test e2e-metal-ipi-ovn-virtualmedia
• /test e2e-metal-single-node-live-iso
• /test e2e-nutanix-ovn
• /test e2e-openstack-ccpmso
• /test e2e-openstack-ccpmso-zone
• /test e2e-openstack-dualstack
• /test e2e-openstack-dualstack-upi
• /test e2e-openstack-externallb
• /test e2e-openstack-nfv-intel
• /test e2e-openstack-proxy
• /test e2e-vsphere-static-ovn
• /test e2e-vsphere-upi-zones
• /test e2e-vsphere-zones
• /test e2e-vsphere-zones-techpreview
• /test okd-e2e-agent-compact-ipv4
• /test okd-e2e-agent-ha-dualstack
• /test okd-e2e-agent-sno-ipv6
• /test okd-e2e-aws-ovn
• /test okd-e2e-aws-ovn-upgrade
• /test okd-e2e-gcp
• /test okd-e2e-gcp-ovn-upgrade
• /test okd-e2e-vsphere
• /test okd-scos-e2e-aws-ovn
• /test okd-scos-e2e-aws-upgrade
• /test okd-scos-e2e-gcp
• /test okd-scos-e2e-gcp-ovn-upgrade
• /test okd-scos-e2e-vsphere
• /test okd-scos-unit
• /test okd-scos-verify-codegen
• /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-openshift-installer-master-altinfra-images
• pull-ci-openshift-installer-master-altinfra-periodics-images
• pull-ci-openshift-installer-master-aro-unit
• pull-ci-openshift-installer-master-e2e-aws-ovn
• pull-ci-openshift-installer-master-gofmt
• pull-ci-openshift-installer-master-golint
• pull-ci-openshift-installer-master-govet
• pull-ci-openshift-installer-master-images
• pull-ci-openshift-installer-master-okd-e2e-aws-ovn-upgrade
• pull-ci-openshift-installer-master-okd-images
• pull-ci-openshift-installer-master-okd-scos-images
• pull-ci-openshift-installer-master-okd-scos-unit
• pull-ci-openshift-installer-master-okd-scos-verify-codegen
• pull-ci-openshift-installer-master-okd-unit
• pull-ci-openshift-installer-master-okd-verify-codegen
• pull-ci-openshift-installer-master-shellcheck
• pull-ci-openshift-installer-master-tf-fmt
• pull-ci-openshift-installer-master-tf-lint
• pull-ci-openshift-installer-master-unit
• pull-ci-openshift-installer-master-verify-codegen
• pull-ci-openshift-installer-master-verify-vendor
• pull-ci-openshift-installer-master-yaml-lint

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[r4f4]

/test altinfra-e2e-aws-ovn

[r4f4]

On my limited testing with the following service endpoints:

platform:
  aws:
    serviceEndpoints:
      - name: ec2
        url: https://ec2.us-east-2.amazonaws.com
      - name: s3
        url: https://s3.us-east-2.amazonaws.com

I see the controller being run with

INFO Running process: aws infrastructure provider with args [-v=4 --diagnostics-address=0 --health-addr=127.0.0.1:43139 --webhook-port=45861 --webhook-cert-dir=/tmp/envtest-serving-certs-4081781335 --feature-gates=BootstrapFormatIgnition=true,ExternalResourceGC=true --service-endpoints=us-east-2:ec2=https://ec2.us-east-2.amazonaws.com,s3=https://s3.us-east-2.amazonaws.com]

[r4f4]

/uncc @sadasu @bfournie
/cc @mtulio @patrickdillon

[mtulio]

/lgtm

[openshift-ci]

@r4f4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade	394893e	link	false	/test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[patrickdillon]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5d5fe31 and 2 for PR HEAD 394893e in total