no-jira: CAPI-Install Feature Gates per Platform by patrickdillon · Pull Request #8311 · openshift/installer

patrickdillon · 2024-04-24T14:57:42Z

Adds the ability to check for a CAPI install feature gate per platform, rather than only checking whether CAPI is enabled for
every platform. This will allow graduation of capi install feature gates per platform.

openshift-ci-robot · 2024-04-24T14:58:25Z

@patrickdillon: This pull request explicitly references no jira issue.

Details

In response to this:

Adds the ability to check for a CAPI install feature gate per platform, rather than only checking whether CAPI is enabled for
every platform. This will allow graduation of capi install feature gates per platform.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pkg/asset/manifests/capiutils/helpers.go

r4f4 · 2024-04-24T22:05:17Z

/hold
For openshift/api#1868 to merge first.

Features moved to a new package in openshift/api in: openshift/api@e00b981 This commit just adapts the installer to use the new packages.

go get github.com/openshift/api@master go mod tidy

go mod vendor

Adds the ability to check for a CAPI install feature gate per platform, rather than only checking whether CAPI is enabled for every platform. This will allow graduation of capi install feature gates per platform.

patrickdillon · 2024-04-29T15:35:43Z

/hold cancel
openshift/api#1868 is now vendored

r4f4

/lgtm

Nice breakdown per commit, easy to review 👍

patrickdillon · 2024-04-29T16:33:09Z

/approve

openshift-ci · 2024-04-29T16:33:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

r4f4 · 2024-04-29T16:38:08Z

The openstack-capi-manifests error might be relevant:

level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: failed to unmarshal install-config.yaml: error converting YAML to JSON: yaml: unmarshal errors:
level=error msg=  line 6: key "featureSet" already set in map

@pierreprinetti can you double check?

openshift-ci-robot · 2024-04-29T16:43:28Z

/retest-required

Remaining retests: 0 against base HEAD c2fa2bf and 2 for PR HEAD cc6a078 in total

r4f4 · 2024-04-29T17:42:18Z

I see the openstack-manifests failure in another PR, so probably not related to the changes in this PR: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/8196/pull-ci-openshift-installer-master-altinfra-openstack-capi-manifests/1784989962907684864

openshift-ci-robot · 2024-04-29T17:46:05Z

/retest-required

Remaining retests: 0 against base HEAD 1a3d6c2 and 1 for PR HEAD cc6a078 in total

openshift-ci-robot · 2024-04-29T20:46:05Z

/retest-required

Remaining retests: 0 against base HEAD 55f8072 and 0 for PR HEAD cc6a078 in total

openshift-ci-robot · 2024-04-29T21:27:39Z

/hold

Revision cc6a078 was retested 3 times: holding

pierreprinetti · 2024-04-30T10:39:02Z

/skip altinfra-openstack-capi-manifests

pierreprinetti · 2024-04-30T10:39:47Z

/hold cancel
openstack-capi-manifests is no longer blocking; we will fix it when we add actual CAPI tests.

pierreprinetti · 2024-04-30T10:47:40Z

/test altinfra-openstack-capi-manifests

r4f4 · 2024-04-30T12:28:27Z

/hold
We'll merge this as soon as #8196 merges.

r4f4 · 2024-04-30T14:33:31Z

/hold cancel

openshift-ci-robot · 2024-04-30T14:52:54Z

/retest-required

Remaining retests: 0 against base HEAD e6b59d5 and 2 for PR HEAD cc6a078 in total

openshift-ci-robot · 2024-04-30T20:28:02Z

/retest-required

Remaining retests: 0 against base HEAD f3d9c1f and 1 for PR HEAD cc6a078 in total

openshift-ci · 2024-05-01T01:35:22Z

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-proxy	`cc6a078`	link	false	`/test e2e-openstack-proxy`
ci/prow/e2e-gcp-secureboot	`cc6a078`	link	false	`/test e2e-gcp-secureboot`
ci/prow/okd-e2e-aws-ovn-upgrade	`cc6a078`	link	false	`/test okd-e2e-aws-ovn-upgrade`
ci/prow/e2e-aws-ovn-single-node	`cc6a078`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/e2e-vsphere-zones	`cc6a078`	link	false	`/test e2e-vsphere-zones`
ci/prow/e2e-gcp-ovn-shared-vpc	`cc6a078`	link	false	`/test e2e-gcp-ovn-shared-vpc`
ci/prow/e2e-azurestack	`cc6a078`	link	false	`/test e2e-azurestack`
ci/prow/altinfra-openstack-capi-manifests	`cc6a078`	link	false	`/test altinfra-openstack-capi-manifests`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2024-05-01T07:07:41Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.17.0-202405010518.p0.gf668504.assembly.stream.el9 for distgit ose-installer-altinfra.
All builds following this will include this PR.

patrickdillon changed the title ~~Capi provider fgs~~ no-jira: CAPI-Install Feature Gates per Platform Apr 24, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2024

openshift-ci bot requested review from AnnaZivkovic and jcpowermac April 24, 2024 15:03

patrickdillon mentioned this pull request Apr 24, 2024

features: add capi-installer gate per platform openshift/api#1868

Merged

patrickdillon force-pushed the capi-provider-fgs branch from 2a358fc to 03a721c Compare April 24, 2024 15:53

r4f4 reviewed Apr 24, 2024

View reviewed changes

pkg/asset/manifests/capiutils/helpers.go Outdated Show resolved Hide resolved

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2024

patrickdillon added 4 commits April 29, 2024 10:43

features: adapt to new o/api features package

b0b170d

Features moved to a new package in openshift/api in: openshift/api@e00b981 This commit just adapts the installer to use the new packages.

go.mod: vendor individual capi feature gates

13f69f0

go get github.com/openshift/api@master go mod tidy

vendor: o/api capi provider feature gates

b1b7bb4

go mod vendor

Check CAPI-Install feature gate per platform

cc6a078

Adds the ability to check for a CAPI install feature gate per platform, rather than only checking whether CAPI is enabled for every platform. This will allow graduation of capi install feature gates per platform.

patrickdillon force-pushed the capi-provider-fgs branch from 03a721c to cc6a078 Compare April 29, 2024 15:33

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024

patrickdillon mentioned this pull request Apr 29, 2024

NO-JIRA: Allow DevPreviewNoUpgrade #8327

Closed

r4f4 reviewed Apr 29, 2024

View reviewed changes

openshift-ci bot assigned r4f4 Apr 29, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024

openshift-merge-bot bot merged commit f668504 into openshift:master May 1, 2024

deads2k mentioned this pull request May 1, 2024

Add DevPreview informing periodics for AWS openshift/release#51098

Closed

Conversation

patrickdillon commented Apr 24, 2024

Uh oh!

openshift-ci-robot commented Apr 24, 2024

Uh oh!

Uh oh!

r4f4 commented Apr 24, 2024

Uh oh!

patrickdillon commented Apr 29, 2024

Uh oh!

r4f4 left a comment

Choose a reason for hiding this comment

Uh oh!

patrickdillon commented Apr 29, 2024

Uh oh!

openshift-ci bot commented Apr 29, 2024

Uh oh!

r4f4 commented Apr 29, 2024

Uh oh!

openshift-ci-robot commented Apr 29, 2024

Uh oh!

r4f4 commented Apr 29, 2024

Uh oh!

openshift-ci-robot commented Apr 29, 2024

Uh oh!

openshift-ci-robot commented Apr 29, 2024

Uh oh!

openshift-ci-robot commented Apr 29, 2024

Uh oh!

pierreprinetti commented Apr 30, 2024

Uh oh!

pierreprinetti commented Apr 30, 2024

Uh oh!

pierreprinetti commented Apr 30, 2024

Uh oh!

r4f4 commented Apr 30, 2024

Uh oh!

r4f4 commented Apr 30, 2024

Uh oh!

openshift-ci-robot commented Apr 30, 2024

Uh oh!

openshift-ci-robot commented Apr 30, 2024

Uh oh!

openshift-ci bot commented May 1, 2024

Uh oh!

openshift-bot commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants