CORS-3460: capi: collect generated assets in hidden dir and save into log bundle#8387
Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom May 15, 2024
Merged
Conversation
Contributor
r4f4
commented
May 9, 2024
r4f4
commented
- This way they don't pollute the workdir neither confuse users by their existence.
- These manifests could provide debugging information about the capi resources configuration and last known state.
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@r4f4: This pull request references CORS-3460 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
Results from local testing: $ tree . -a
.
├── auth
│ ├── envtest.kubeconfig
│ ├── kubeadmin-password
│ └── kubeconfig
├── bin
├── .capi_output
│ ├── AWSClusterControllerIdentity--default.yaml
│ ├── AWSCluster-openshift-cluster-api-guests-rdossant-installer-05-lr98z.yaml
│ ├── AWSMachine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-bootstrap.yaml
│ ├── AWSMachine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master-0.yaml
│ ├── AWSMachine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master-1.yaml
│ ├── AWSMachine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master-2.yaml
│ ├── Cluster-openshift-cluster-api-guests-rdossant-installer-05-lr98z.yaml
│ ├── Machine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-bootstrap.yaml
│ ├── Machine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master-0.yaml
│ ├── Machine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master-1.yaml
│ ├── Machine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master-2.yaml
│ ├── Namespace--openshift-cluster-api-guests.yaml
│ ├── Secret-openshift-cluster-api-guests-rdossant-installer-05-lr98z-bootstrap.yaml
│ └── Secret-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master.yaml
├── metadata.json
├── openshift-install
├── .openshift_install.log
├── .openshift_install_state.json
├── terraform.platform.auto.tfvars.json
├── terraform.tfvars.json
└── tls
├── journal-gatewayd.crt
└── journal-gatewayd.key
5 directories, 25 files$ tar tvf log-bundle-20240510004759.tar.gz --wildcards '*/clusterapi/*'
-rw-r----- root/root 124046 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/AWSCluster-openshift-cluster-api-guests-rdossant-installer-05-lr98z.yaml
-rw-r----- root/root 1703 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/AWSClusterControllerIdentity--default.yaml
-rw-r----- root/root 15858 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/AWSMachine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-bootstrap.yaml
-rw-r----- root/root 15237 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/AWSMachine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master-0.yaml
-rw-r----- root/root 15239 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/AWSMachine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master-1.yaml
-rw-r----- root/root 15241 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/AWSMachine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master-2.yaml
-rw-r----- root/root 8527 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/Cluster-openshift-cluster-api-guests-rdossant-installer-05-lr98z.yaml
-rw-r----- root/root 8818 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/Machine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-bootstrap.yaml
-rw-r----- root/root 8676 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/Machine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master-0.yaml
-rw-r----- root/root 8678 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/Machine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master-1.yaml
-rw-r----- root/root 8678 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/Machine-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master-2.yaml
-rw-r----- root/root 1546 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/Namespace--openshift-cluster-api-guests.yaml
-rw-r----- root/root 2234089 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/Secret-openshift-cluster-api-guests-rdossant-installer-05-lr98z-bootstrap.yaml
-rw-r----- root/root 15149 2024-05-09 21:08 log-bundle-20240510004759/clusterapi/Secret-openshift-cluster-api-guests-rdossant-installer-05-lr98z-master.yaml |
Contributor
Author
|
/uncc @AnnaZivkovic @pawanpinjarkar |
openshift-ci
bot
requested review from
barbacbd and
patrickdillon
and removed request for
AnnaZivkovic and
pawanpinjarkar
Contributor
Author
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Contributor
Author
|
/test altinfra-e2e-aws-ovn |
Contributor
Author
It seems the way I did it is it's not triggering the Trying again. |
r4f4
force-pushed
the
capi-manifests-hidden-dir
branch
from
629aa82 to
9f5f3ff
Compare
Contributor
Author
|
/test altinfra-e2e-aws-ovn |
2 similar comments
Contributor
Author
|
/test altinfra-e2e-aws-ovn |
Contributor
Author
|
/test altinfra-e2e-aws-ovn |
r4f4
force-pushed
the
capi-manifests-hidden-dir
branch
from
9f5f3ff to
d3c5fa1
Compare
Contributor
Author
|
I think I was stopping the bootstrap too early. Let's try again: |
Contributor
Author
|
I was saving the capi manifests in the wrong path and didn't realize it because I ran the Installer from a container and the workdir was an absolute path. /test altinfra-e2e-aws-ovn |
Contributor
Author
$ tar tfv log-bundle-20240510203407.tar --wildcards '*/clusterapi/*'
-rw-r----- 1003980000/root 118472 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/AWSCluster-openshift-cluster-api-guests-ci-op-p2rftdc3-2d061-ss7sj.yaml
-rw-r----- 1003980000/root 1703 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/AWSClusterControllerIdentity--default.yaml
-rw-r----- 1003980000/root 16603 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/AWSMachine-openshift-cluster-api-guests-ci-op-p2rftdc3-2d061-ss7sj-bootstrap.yaml
-rw-r----- 1003980000/root 15977 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/AWSMachine-openshift-cluster-api-guests-ci-op-p2rftdc3-2d061-ss7sj-master-0.yaml
-rw-r----- 1003980000/root 15978 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/AWSMachine-openshift-cluster-api-guests-ci-op-p2rftdc3-2d061-ss7sj-master-1.yaml
-rw-r----- 1003980000/root 15983 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/AWSMachine-openshift-cluster-api-guests-ci-op-p2rftdc3-2d061-ss7sj-master-2.yaml
-rw-r----- 1003980000/root 7959 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/Cluster-openshift-cluster-api-guests-ci-op-p2rftdc3-2d061-ss7sj.yaml
-rw-r----- 1003980000/root 8817 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/Machine-openshift-cluster-api-guests-ci-op-p2rftdc3-2d061-ss7sj-bootstrap.yaml
-rw-r----- 1003980000/root 8675 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/Machine-openshift-cluster-api-guests-ci-op-p2rftdc3-2d061-ss7sj-master-0.yaml
-rw-r----- 1003980000/root 8675 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/Machine-openshift-cluster-api-guests-ci-op-p2rftdc3-2d061-ss7sj-master-1.yaml
-rw-r----- 1003980000/root 8677 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/Machine-openshift-cluster-api-guests-ci-op-p2rftdc3-2d061-ss7sj-master-2.yaml
-rw-r----- 1003980000/root 1546 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/Namespace--openshift-cluster-api-guests.yaml
-rw-r----- 1003980000/root 2596440 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/Secret-openshift-cluster-api-guests-ci-op-p2rftdc3-2d061-ss7sj-bootstrap.yaml
-rw-r----- 1003980000/root 15167 2024-05-10 22:21 log-bundle-20240510203407/clusterapi/Secret-openshift-cluster-api-guests-ci-op-p2rftdc3-2d061-ss7sj-master.yaml |
r4f4
force-pushed
the
capi-manifests-hidden-dir
branch
from
cac0e31 to
21f0427
Compare
Contributor
Author
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Contributor
Author
|
In the terraform-based job: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/8387/pull-ci-openshift-installer-master-e2e-aws-ovn/1788993024060035072 |
Contributor
patrickdillon
left a comment
patrickdillon
left a comment
There was a problem hiding this comment.
ug sorry @r4f4 I started this comment in a pending review and never submitted it
This way they don't pollute the workdir neither confuse users by their existence.
These manifests could provide debugging information about the capi resources configuration and last known state.
r4f4
force-pushed
the
capi-manifests-hidden-dir
branch
from
21f0427 to
fa8074a
Compare
Contributor
Author
|
Update: addressed review feedback. |
Contributor
|
/lgtm |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
@r4f4: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.