OCPBUGS-35752: capi/aws: disable EKS controller in CAPA by r4f4 · Pull Request #8628 · openshift/installer

r4f4 · 2024-06-18T16:29:31Z

The EKS controller feature gate is enabled by default in CAPA, which causes the following lines to show up in the logs:

time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613409     349 logger.go:75] \"enabling EKS controllers and webhooks\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613416     349 logger.go:81] \"EKS IAM role creation\" logger=\"setup\" enabled=false"
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613420     349 logger.go:81] \"EKS IAM additional roles\" logger=\"setup\" enabled=false"
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613425     349 logger.go:81] \"enabling EKS control plane controller\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613449     349 logger.go:81] \"enabling EKS bootstrap controller\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613464     349 logger.go:81] \"enabling EKS managed cluster controller\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613496     349 logger.go:81] \"enabling EKS managed machine pool controller\" logger=\"setup\""

Although harmless, they can be confusing for users. This change disables the feature so the lines are gone and we are not running controllers unnecessarily.

The EKS controller feature gate is enabled by default in CAPA, which causes the following lines to show up in the logs: ``` time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613409 349 logger.go:75] \"enabling EKS controllers and webhooks\" logger=\"setup\"" time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613416 349 logger.go:81] \"EKS IAM role creation\" logger=\"setup\" enabled=false" time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613420 349 logger.go:81] \"EKS IAM additional roles\" logger=\"setup\" enabled=false" time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613425 349 logger.go:81] \"enabling EKS control plane controller\" logger=\"setup\"" time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613449 349 logger.go:81] \"enabling EKS bootstrap controller\" logger=\"setup\"" time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613464 349 logger.go:81] \"enabling EKS managed cluster controller\" logger=\"setup\"" time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613496 349 logger.go:81] \"enabling EKS managed machine pool controller\" logger=\"setup\"" ``` Although harmless, they can be confusing for users. This change disables the feature so the lines are gone and we are not running controllers unnecessarily.

openshift-ci-robot · 2024-06-18T16:29:38Z

@r4f4: This pull request references Jira Issue OCPBUGS-35752, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.17.0) matches configured target version for branch (4.17.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The EKS controller feature gate is enabled by default in CAPA, which causes the following lines to show up in the logs:

time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613409     349 logger.go:75] \"enabling EKS controllers and webhooks\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613416     349 logger.go:81] \"EKS IAM role creation\" logger=\"setup\" enabled=false"
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613420     349 logger.go:81] \"EKS IAM additional roles\" logger=\"setup\" enabled=false"
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613425     349 logger.go:81] \"enabling EKS control plane controller\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613449     349 logger.go:81] \"enabling EKS bootstrap controller\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613464     349 logger.go:81] \"enabling EKS managed cluster controller\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613496     349 logger.go:81] \"enabling EKS managed machine pool controller\" logger=\"setup\""

Although harmless, they can be confusing for users. This change disables the feature so the lines are gone and we are not running controllers unnecessarily.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

r4f4 · 2024-06-18T16:35:14Z

Here is the feature gate: https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/feature/feature.go#L99
And here is an example of the presence of those log lines:

time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613409     349 logger.go:75] \"enabling EKS controllers and webhooks\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613416     349 logger.go:81] \"EKS IAM role creation\" logger=\"setup\" enabled=false"
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613420     349 logger.go:81] \"EKS IAM additional roles\" logger=\"setup\" enabled=false"
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613425     349 logger.go:81] \"enabling EKS control plane controller\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613449     349 logger.go:81] \"enabling EKS bootstrap controller\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613464     349 logger.go:81] \"enabling EKS managed cluster controller\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613496     349 logger.go:81] \"enabling EKS managed machine pool controller\" logger=\"setup\""

r4f4 · 2024-06-18T16:58:58Z

/uncc @andfasano @rwsu
/cc @patrickdillon @mtulio

r4f4 · 2024-06-18T18:11:43Z

e2e-aws-ovn build log:
the only "EKS" in the output logs is

time="2024-06-18T17:28:09Z" level=info msg="Running process: aws infrastructure provider with args [-v=4 --diagnostics-address=0 --health-addr=127.0.0.1:40743 --webhook-port=42143 --webhook-cert-dir=/tmp/envtest-serving-certs-3083662382 --feature-gates=BootstrapFormatIgnition=true,ExternalResourceGC=true,TagUnmanagedNetworkResources=false,EKS=false --kubeconfig=/tmp/installer/.clusterapi_output/envtest.kubeconfig]"
time="2024-06-18T17:28:09Z" level=debug msg="I0618 17:28:09.091194     355 logger.go:75] \"feature gates: BootstrapFormatIgnition=true,EKS=false,ExternalResourceGC=true,TagUnmanagedNetworkResources=false\\n\" logger=\"setup\""

r4f4 · 2024-06-18T21:53:19Z

/assign @patrickdillon

mtulio

LGTM with suggestions.
/lgtm

mtulio · 2024-06-19T00:24:20Z

pkg/clusterapi/system.go

 				"--webhook-port={{.WebhookPort}}",
 				"--webhook-cert-dir={{.WebhookCertDir}}",
-				"--feature-gates=BootstrapFormatIgnition=true,ExternalResourceGC=true,TagUnmanagedNetworkResources=false",
+				"--feature-gates=BootstrapFormatIgnition=true,ExternalResourceGC=true,TagUnmanagedNetworkResources=false,EKS=false",


@r4f4 looks like FG AutoControllerIdentityCreator(1) is also enabled(2) by default in the current version, are we using it or should we disable it?

I was looking if we have an easy way to "disable-all" then enable desired to prevent upstream changes introducing new unwanted features, or disable something we are using, but it looks like there is not possible.

@mtulio we use that one here

But one that is currently disabled by default and we could add to the list is the ROSA one

patrickdillon · 2024-07-02T13:59:38Z

/approve

openshift-ci · 2024-07-02T14:00:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-07-02T16:45:24Z

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-07-02T16:49:39Z

@r4f4: Jira Issue OCPBUGS-35752: All pull requests linked via external trackers have merged:

openshift/installer#8628

Jira Issue OCPBUGS-35752 has been moved to the MODIFIED state.

Details

In response to this:

The EKS controller feature gate is enabled by default in CAPA, which causes the following lines to show up in the logs:

time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613409     349 logger.go:75] \"enabling EKS controllers and webhooks\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613416     349 logger.go:81] \"EKS IAM role creation\" logger=\"setup\" enabled=false"
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613420     349 logger.go:81] \"EKS IAM additional roles\" logger=\"setup\" enabled=false"
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613425     349 logger.go:81] \"enabling EKS control plane controller\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613449     349 logger.go:81] \"enabling EKS bootstrap controller\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613464     349 logger.go:81] \"enabling EKS managed cluster controller\" logger=\"setup\""
time="2024-06-18T11:43:59Z" level=debug msg="I0618 11:43:59.613496     349 logger.go:81] \"enabling EKS managed machine pool controller\" logger=\"setup\""

Although harmless, they can be confusing for users. This change disables the feature so the lines are gone and we are not running controllers unnecessarily.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

r4f4 · 2024-07-02T16:53:52Z

/cherry-pick release-4.16

openshift-cherrypick-robot · 2024-07-02T16:54:52Z

@r4f4: new pull request created: #8694

Details

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 18, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 18, 2024

openshift-ci bot requested review from andfasano, gpei and rwsu June 18, 2024 16:29

openshift-ci bot requested review from mtulio and patrickdillon and removed request for andfasano and rwsu June 18, 2024 16:59

openshift-ci bot assigned patrickdillon Jun 18, 2024

mtulio reviewed Jun 19, 2024

View reviewed changes

openshift-ci bot assigned mtulio Jun 19, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024

openshift-merge-bot bot merged commit 0115fda into openshift:master Jul 2, 2024

openshift-cherrypick-robot mentioned this pull request Jul 2, 2024

[release-4.16] OCPBUGS-36447: capi/aws: disable EKS controller in CAPA #8694

Merged

Conversation

r4f4 commented Jun 18, 2024

Uh oh!

openshift-ci-robot commented Jun 18, 2024

Uh oh!

r4f4 commented Jun 18, 2024

Uh oh!

r4f4 commented Jun 18, 2024

Uh oh!

r4f4 commented Jun 18, 2024

Uh oh!

r4f4 commented Jun 18, 2024

Uh oh!

mtulio left a comment

Choose a reason for hiding this comment

Uh oh!

mtulio Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

r4f4 Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

r4f4 Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

patrickdillon commented Jul 2, 2024

Uh oh!

openshift-ci bot commented Jul 2, 2024

Uh oh!

openshift-ci bot commented Jul 2, 2024

Uh oh!

openshift-ci-robot commented Jul 2, 2024

Uh oh!

r4f4 commented Jul 2, 2024

Uh oh!

openshift-cherrypick-robot commented Jul 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants