OCPBUGS-36904: aws: bump CAPA for subnet tagging fix by r4f4 · Pull Request #8730 · openshift/installer

r4f4 · 2024-07-12T17:02:54Z

This bump includes the following fix:

🐛 subnets: use "owned" k8s tag value for managed subnets. kubernetes-sigs/cluster-api-provider-aws#5051

openshift-ci-robot · 2024-07-12T17:02:59Z

@r4f4: This pull request references Jira Issue OCPBUGS-36904, which is invalid:

expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This bump includes the following fix:

🐛 subnets: use "owned" k8s tag value for managed subnets. kubernetes-sigs/cluster-api-provider-aws#5051

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

r4f4 · 2024-07-12T17:03:20Z

Marking as WIP until the upstream PR is accepted.

r4f4 · 2024-07-12T17:05:07Z

/uncc @patrickdillon @sadasu
Will cc back in when it's ready for review.

This bump includes the following fix: * kubernetes-sigs/cluster-api-provider-aws#5051

r4f4 · 2024-07-16T20:41:50Z

/retitle OCPBUGS-36904: aws: bump CAPA for subnet tagging fix

Upstream PR has merged, removing WIP.

r4f4 · 2024-07-16T20:44:21Z

/jira refresh

openshift-ci-robot · 2024-07-16T20:44:28Z

@r4f4: This pull request references Jira Issue OCPBUGS-36904, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.17.0) matches configured target version for branch (4.17.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

r4f4 · 2024-07-16T20:44:44Z

/cc @patrickdillon @sadasu
This is ready for review now.

r4f4 · 2024-07-16T20:45:03Z

/label acknowledge-critical-fixes-only

r4f4 · 2024-07-16T20:45:22Z

/label platform/aws

r4f4 · 2024-07-17T08:25:30Z

/test altinfra-e2e-aws-ovn

r4f4 · 2024-07-19T13:57:33Z

/retest-required

openshift-ci · 2024-07-19T16:30:08Z

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones	`6551aab`	link	false	`/test e2e-aws-ovn-shared-vpc-edge-zones`
ci/prow/e2e-external-aws-ccm	`6551aab`	link	false	`/test e2e-external-aws-ccm`
ci/prow/e2e-aws-ovn-edge-zones	`6551aab`	link	false	`/test e2e-aws-ovn-edge-zones`
ci/prow/e2e-aws-ovn-single-node	`6551aab`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/e2e-aws-ovn-heterogeneous	`6551aab`	link	false	`/test e2e-aws-ovn-heterogeneous`
ci/prow/e2e-aws-ovn-shared-vpc-custom-security-groups	`6551aab`	link	false	`/test e2e-aws-ovn-shared-vpc-custom-security-groups`
ci/prow/e2e-aws-ovn-fips	`6551aab`	link	false	`/test e2e-aws-ovn-fips`
ci/prow/e2e-aws-ovn-imdsv2	`6551aab`	link	false	`/test e2e-aws-ovn-imdsv2`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

sadasu · 2024-07-23T12:41:59Z

/approve

sadasu · 2024-07-23T12:42:08Z

/retest-required

openshift-ci · 2024-07-23T12:42:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sadasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

barbacbd

/lgtm

openshift-ci-robot · 2024-07-23T20:02:14Z

/retest-required

Remaining retests: 0 against base HEAD 4bdd07d and 2 for PR HEAD 6551aab in total

openshift-ci-robot · 2024-07-23T23:11:37Z

@r4f4: Jira Issue OCPBUGS-36904: All pull requests linked via external trackers have merged:

openshift/installer#8730

Jira Issue OCPBUGS-36904 has been moved to the MODIFIED state.

Details

In response to this:

This bump includes the following fix:

🐛 subnets: use "owned" k8s tag value for managed subnets. kubernetes-sigs/cluster-api-provider-aws#5051

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-07-24T03:46:37Z

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.18.0-202407240243.p0.g2623fb6.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-07-24T04:01:37Z

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.18.0-202407240243.p0.g2623fb6.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-07-24T04:22:35Z

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.18.0-202407240243.p0.g2623fb6.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-07-24T06:04:41Z

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.18.0-202407240243.p0.g2623fb6.assembly.stream.el9.
All builds following this will include this PR.

r4f4 · 2024-07-24T12:08:51Z

/cherry-pick release-4.16

openshift-cherrypick-robot · 2024-07-24T12:09:52Z

@r4f4: #8730 failed to apply on top of branch "release-4.16":

Applying: OCPBUGS-36904: aws: bump CAPA for subnet tagging fix
Using index info to reconstruct a base tree...
M	cluster-api/providers/aws/go.mod
M	go.mod
M	go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging cluster-api/providers/aws/go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-36904: aws: bump CAPA for subnet tagging fix
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2024

openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 12, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 12, 2024

openshift-ci bot requested review from patrickdillon and sadasu July 12, 2024 17:04

openshift-ci bot removed request for patrickdillon and sadasu July 12, 2024 17:05

r4f4 mentioned this pull request Jul 12, 2024

🐛 subnets: use "owned" k8s tag value for managed subnets. kubernetes-sigs/cluster-api-provider-aws#5051

Merged

5 tasks

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2024

r4f4 added 2 commits July 16, 2024 22:38

OCPBUGS-36904: aws: bump CAPA for subnet tagging fix

43a6ca4

This bump includes the following fix: * kubernetes-sigs/cluster-api-provider-aws#5051

capi/aws: update vendor

6551aab

r4f4 force-pushed the aws-subnet-tags-fix branch from 58aa927 to 6551aab Compare July 16, 2024 20:40

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2024

openshift-ci bot changed the title ~~WIP: OCPBUGS-36904: aws: bump CAPA for subnet tagging fix~~ OCPBUGS-36904: aws: bump CAPA for subnet tagging fix Jul 16, 2024

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 16, 2024

openshift-ci bot requested a review from gpei July 16, 2024 20:44

openshift-ci bot requested review from patrickdillon and sadasu July 16, 2024 20:44

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jul 16, 2024

openshift-ci bot added the platform/aws label Jul 16, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024

barbacbd reviewed Jul 23, 2024

View reviewed changes

openshift-ci bot assigned barbacbd Jul 23, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024

openshift-merge-bot bot merged commit 2623fb6 into openshift:master Jul 23, 2024

r4f4 mentioned this pull request Jul 24, 2024

OCPBUGS-37510: [release-4.16] aws: bump CAPA for subnet tagging fix #8772

Merged

Conversation

r4f4 commented Jul 12, 2024

Uh oh!

openshift-ci-robot commented Jul 12, 2024

Uh oh!

r4f4 commented Jul 12, 2024

Uh oh!

r4f4 commented Jul 12, 2024

Uh oh!

r4f4 commented Jul 16, 2024

Uh oh!

r4f4 commented Jul 16, 2024

Uh oh!

openshift-ci-robot commented Jul 16, 2024

Uh oh!

r4f4 commented Jul 16, 2024

Uh oh!

r4f4 commented Jul 16, 2024

Uh oh!

r4f4 commented Jul 16, 2024

Uh oh!

r4f4 commented Jul 17, 2024

Uh oh!

r4f4 commented Jul 19, 2024

Uh oh!

openshift-ci bot commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sadasu commented Jul 23, 2024

Uh oh!

sadasu commented Jul 23, 2024

Uh oh!

openshift-ci bot commented Jul 23, 2024

Uh oh!

barbacbd left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jul 23, 2024

Uh oh!

openshift-ci-robot commented Jul 23, 2024

Uh oh!

openshift-bot commented Jul 24, 2024

Uh oh!

openshift-bot commented Jul 24, 2024

Uh oh!

openshift-bot commented Jul 24, 2024

Uh oh!

openshift-bot commented Jul 24, 2024

Uh oh!

r4f4 commented Jul 24, 2024

Uh oh!

openshift-cherrypick-robot commented Jul 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openshift-ci bot commented Jul 19, 2024 •

edited

Loading