Skip to content

OCPBUGS-38235: upi/aws: update lambda runtime python version#8820

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
r4f4:upi-aws-python-ver
Aug 26, 2024
Merged

OCPBUGS-38235: upi/aws: update lambda runtime python version#8820
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
r4f4:upi-aws-python-ver

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Aug 10, 2024

The usage of python3.8 in lambda runtimes is being deprecated soon (Oct 14, 2024) [1]. This change updates it to python3.9 which is the default version in RHEL 9.

[1] https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 10, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-38235, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The usage of python3.8 in lambda runtimes is being deprecated soon (Oct 14, 2024) [1]. This change updates it to python3.9 which is the default version in RHEL 9.

[1] https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from mtulio and patrickdillon August 10, 2024 11:14
@r4f4
Copy link
Contributor Author

r4f4 commented Aug 10, 2024

/jira backport release-4.17,release-4.16

@r4f4
Copy link
Contributor Author

r4f4 commented Aug 10, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 10, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.17
/cherrypick release-4.16

Details

In response to this:

/jira backport release-4.17,release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 10, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-38235, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

Details

In response to this:

@r4f4: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.17
/cherrypick release-4.16

In response to this:

/jira backport release-4.17,release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested a review from gpei August 10, 2024 11:18
@r4f4 r4f4 force-pushed the upi-aws-python-ver branch from 8501b61 to 1306754 Compare August 10, 2024 11:19
@gpei
Copy link
Contributor

gpei commented Aug 12, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 12, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-38235, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

The usage of python3.8 in lambda runtimes is being deprecated soon (Oct 14, 2024) [1]. This change updates it to python3.9 which is the default version in RHEL 9.

[1] https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2024
The usage of python3.8 in lambda runtimes is being deprecated soon (Oct
14, 2024). This change updates it to python3.11 which can be easily
installed in RHEL 9.
@r4f4 r4f4 force-pushed the upi-aws-python-ver branch from 1306754 to d0ed543 Compare August 19, 2024 12:08
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Aug 19, 2024

Update: changed from python3.9 to python3.11 since python3.9 EOL in Oct 2025.

Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
@rna-afk
Copy link
Contributor

rna-afk commented Aug 20, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rna-afk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c4b28e5 and 2 for PR HEAD d0ed543 in total

@r4f4
Copy link
Contributor Author

r4f4 commented Aug 21, 2024

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 317a28f and 1 for PR HEAD d0ed543 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 288a795 and 0 for PR HEAD d0ed543 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision d0ed543 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Aug 22, 2024

/hold cancel

/test e2e-aws-ovn-upi

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5ca6e2e and 2 for PR HEAD d0ed543 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 54e17ae and 1 for PR HEAD d0ed543 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 54e17ae and 2 for PR HEAD d0ed543 in total

@r4f4
Copy link
Contributor Author

r4f4 commented Aug 22, 2024

/test e2e-aws-ovn-upi

@r4f4
Copy link
Contributor Author

r4f4 commented Aug 22, 2024

/test e2e-aws-ovn

@r4f4
Copy link
Contributor Author

r4f4 commented Aug 23, 2024

/test e2e-aws-ovn-upi

@r4f4
Copy link
Contributor Author

r4f4 commented Aug 24, 2024

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Aug 24, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4adfd12 and 2 for PR HEAD d0ed543 in total

@r4f4
Copy link
Contributor Author

r4f4 commented Aug 24, 2024

/test e2e-aws-ovn-upi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2024

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-vsphere-ovn 1306754a49672c80653307e9987b2041ab918bfd link false /test okd-scos-e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones d0ed543 link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-aws-ovn-single-node d0ed543 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor Author

r4f4 commented Aug 26, 2024

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 3846e32 into openshift:master Aug 26, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: Jira Issue OCPBUGS-38235: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38235 has been moved to the MODIFIED state.

Details

In response to this:

The usage of python3.8 in lambda runtimes is being deprecated soon (Oct 14, 2024) [1]. This change updates it to python3.9 which is the default version in RHEL 9.

[1] https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@openshift-ci-robot: new pull request created: #8896

Details

In response to this:

@r4f4: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.17
/cherrypick release-4.16

In response to this:

/jira backport release-4.17,release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@openshift-ci-robot: new pull request created: #8897

Details

In response to this:

@r4f4: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.17
/cherrypick release-4.16

In response to this:

/jira backport release-4.17,release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants