Skip to content

OCPBUGS-41852: add tested IBMCloud instance types in 4.17 test#8932

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
MayXuQQ:ibm_vmtype
Sep 17, 2024
Merged

OCPBUGS-41852: add tested IBMCloud instance types in 4.17 test#8932
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
MayXuQQ:ibm_vmtype

Conversation

@MayXuQQ
Copy link
Contributor

@MayXuQQ MayXuQQ commented Sep 1, 2024

add new vm type found in 4.17 test.
OCPBUGS-41852

@openshift-ci openshift-ci bot requested review from barbacbd and bfournie September 1, 2024 14:17
@MayXuQQ MayXuQQ changed the title add ibm type in 4.17 test add ibm VM types found in 4.17 test Sep 1, 2024
@MayXuQQ MayXuQQ changed the title add ibm VM types found in 4.17 test add tested IBMCloud instance types in 4.17 test Sep 2, 2024
@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Sep 2, 2024

@sadasu could you help review it, thanks a lot

* `mx2-8x64`
* `mx2d-4x32`
* `mx3d-2x20`
* `ox2-4x32`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we no longer support these types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace mx3d-2x20 with 'mx3d-4x40 '
replace ox2-4x32 with ox2-8x64

  1. list one type in the same profiles
  2. use the larger to support the master and workers.

@sadasu
Copy link
Contributor

sadasu commented Sep 9, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Sep 12, 2024

/test e2e-ibmcloud-ovn

@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Sep 12, 2024

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

@MayXuQQ: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-ovn 8a7688c link false /test e2e-ibmcloud-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MayXuQQ MayXuQQ changed the title add tested IBMCloud instance types in 4.17 test OCPBUGS-41852 add tested IBMCloud instance types in 4.17 test Sep 12, 2024
@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Sep 12, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@MayXuQQ: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MayXuQQ MayXuQQ changed the title OCPBUGS-41852 add tested IBMCloud instance types in 4.17 test OCPBUGS-41852: add tested IBMCloud instance types in 4.17 test Sep 12, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 12, 2024
@openshift-ci-robot
Copy link
Contributor

@MayXuQQ: This pull request references Jira Issue OCPBUGS-41852, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

add new vm type found in 4.17 test.
OCPBUGS-41852

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Sep 12, 2024

/jira refresh

1 similar comment
@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Sep 12, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 12, 2024
@openshift-ci-robot
Copy link
Contributor

@MayXuQQ: This pull request references Jira Issue OCPBUGS-41852, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @MayXuQQ

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: MayXuQQ.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@MayXuQQ: This pull request references Jira Issue OCPBUGS-41852, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @MayXuQQ

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Sep 13, 2024

@sadasu could you give a lgtm? thanks

@sadasu
Copy link
Contributor

sadasu commented Sep 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 062c514 into openshift:master Sep 17, 2024
@openshift-ci-robot
Copy link
Contributor

@MayXuQQ: Jira Issue OCPBUGS-41852: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41852 has been moved to the MODIFIED state.

Details

In response to this:

add new vm type found in 4.17 test.
OCPBUGS-41852

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Sep 18, 2024

/cherry-pick release-4.17

@openshift-cherrypick-robot

@MayXuQQ: new pull request created: #9030

Details

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants