Skip to content

Create temporary service VM and document the current state of experimental OpenStack support#904

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
russellb:openstack-hacks
Dec 14, 2018
Merged

Create temporary service VM and document the current state of experimental OpenStack support#904
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
russellb:openstack-hacks

Conversation

@russellb
Copy link
Contributor

OpenStack support is still experimental and requires some hacks to get the cluster up and running. This patch merges those hacks so that people can get a better experience that are giving it a try. The service VM is temporary and will be removed before OpenStack is supported.

This PR also includes a doc where we can keep notes on the state of OpenStack support.

This patch introduces a temporary service VM, that provides enough DNS and LB
functionality to bring up the cluster. It's a VM running dnsmasq to provide the
required DNS records necessary to bring up the cluster and haproxy to LB
against the master nodes for the API.

OpenStack support will remain experimental as long as this VM exists, but it
provides a better test and dev experience while we work on improving.

This includes the folowing additional cleanups in passing:
 - drop unused console security group
 - hack to disable openstack cloud provider temporarily while some issues
   are resolved

Co-authored-by: Flavio Percoco <flavio@redhat.com>
Co-authored-by: Tomas Sedovic <tsedovic@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 14, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2018
@russellb
Copy link
Contributor Author

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The libvirt docs live under docs/dev because they are never intended to be user-facing. OpenStack, on the other hand, is intended to be user-facing and just hasn't graduated to non-experimental yet. Can we put this in docs/user/openshift/README.md or some such and open with:

# OpenStack

**Support for launching clusters on OpenStack is experimental.**

or some such? Then we can just remove the caveat when we feel comfortable with it, and won't cause downstream issues with breaking links and such.

Using an openstack directory also gives us a place to drop an OWNERS file so we can one day return to having separate per-platform mantainers.

How does that sound?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great. I'll fix it up.

The pointer to how to set up a development environment is dev specific, so maybe I'll leave a small openstack dev doc for that.

There's also some more content from #909 I'll pull in.

Thanks for the quick feedback!

Document current requirements and expected behavior of OpenStack support.  Also
create a dev doc that points to how to set up a dev env.
path = "/etc/haproxy/haproxy.cfg"

source {
source = "data:,listen%20ostest-api-80%0D%0A%20%20%20%20bind%200.0.0.0%3A80%0D%0A%20%20%20%20mode%20tcp%0D%0A%20%20%20%20stats%20enable%0D%0A%20%20%20%20stats%20uri%20%2Fhaproxy%3Fstatus%0D%0A%20%20%20%20balance%20roundrobin%0D%0A%20%20%20%20server%20ostest-bootstrap%20ostest-bootstrap.shiftstack.com%3A80%20check%0D%0A%20%20%20%20server%20ostest-master-0%20ostest-master-0.shiftstack.com%3A80%20check%0D%0A%20%20%20%20server%20ostest-master-1%20ostest-master-1.shiftstack.com%3A80%20check%0D%0A%20%20%20%20server%20ostest-master-2%20ostest-master-2.shiftstack.com%3A80%20check%0D%0A%0D%0Alisten%20ostest-api-6443%0D%0A%20%20%20%20bind%200.0.0.0%3A6443%0D%0A%20%20%20%20mode%20tcp%0D%0A%20%20%20%20stats%20enable%0D%0A%20%20%20%20stats%20uri%20%2Fhaproxy%3Fstatus%0D%0A%20%20%20%20balance%20roundrobin%0D%0A%20%20%20%20server%20ostest-bootstrap%20ostest-bootstrap.shiftstack.com%3A6443%20check%0D%0A%20%20%20%20server%20ostest-master-0%20ostest-master-0.shiftstack.com%3A6443%20check%0D%0A%20%20%20%20server%20ostest-master-1%20ostest-master-1.shiftstack.com%3A6443%20check%0D%0A%20%20%20%20server%20ostest-master-2%20ostest-master-2.shiftstack.com%3A6443%20check%0D%0A%0D%0Alisten%20ostest-api-443%0D%0A%20%20%20%20bind%200.0.0.0%3A443%0D%0A%20%20%20%20mode%20tcp%0D%0A%20%20%20%20stats%20enable%0D%0A%20%20%20%20stats%20uri%20%2Fhaproxy%3Fstatus%0D%0A%20%20%20%20balance%20roundrobin%0D%0A%20%20%20%20server%20ostest-bootstrap%20ostest-bootstrap.shiftstack.com%3A443%20check%0D%0A%20%20%20%20server%20ostest-master-0%20ostest-master-0.shiftstack.com%3A443%20check%0D%0A%20%20%20%20server%20ostest-master-1%20ostest-master-1.shiftstack.com%3A443%20check%0D%0A%20%20%20%20server%20ostest-master-2%20ostest-master-2.shiftstack.com%3A443%20check%0D%0A%0D%0Alisten%20ostest-api-49500%0D%0A%20%20%20%20bind%200.0.0.0%3A49500%0D%0A%20%20%20%20mode%20tcp%0D%0A%20%20%20%20stats%20enable%0D%0A%20%20%20%20stats%20uri%20%2Fhaproxy%3Fstatus%0D%0A%20%20%20%20balance%20roundrobin%0D%0A%20%20%20%20server%20ostest-bootstrap%20ostest-bootstrap.shiftstack.com%3A49500%20check%0D%0A%20%20%20%20server%20ostest-master-0%20ostest-master-0.shiftstack.com%3A49500%20check%0D%0A%20%20%20%20server%20ostest-master-1%20ostest-master-1.shiftstack.com%3A49500%20check%0D%0A%20%20%20%20server%20ostest-master-2%20ostest-master-2.shiftstack.com%3A49500%20check"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case, this config is hardcoded for the instances to be named ostest-<name>.shiftstack.com

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we'll have to change this. Let's go with it as-is for now and figure a way to not have it hardcoded in a follow-up patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, oops, I missed that.

Yeah, should be easy enough to fix. I think these things are already in variables.

@flaper87
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, russellb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2897ed7 into openshift:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants