[release-4.16] OCPBUGS-41813: Validate MTU for custom network#9104
Conversation
Set the minimum MTU to 1380 when deploying on IPv6. This value corresponds to the minimum MTU for IPv6, which is 1280, and the ovn-kubernetes overhead, which is 100.
The minimum MTU for the IPv6 network was previously only enforced when the controlPlanePort used the Network filter. This commit change the validation to also work when using the Subnet filter from FixedIPs. This commit does two things: - populate the ControlPlanePortNetwork struct in CloudInfo even when using the Subnet filter and not the Network one. - move the validation for MTU out of the branch for Network filter from the install-config.yaml
openshift-ci-robot
added
jira/valid-reference
|
@mandre: This pull request references Jira Issue OCPBUGS-41813, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira backport release-4.15 |
|
@mandre: The following backport issues have been created:
Queuing cherrypicks to the requested branches to be created after this PR merges: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@mandre: This pull request references Jira Issue OCPBUGS-41813, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
/label backport-risk-assessed
openshift-ci
bot
added
the
backport-risk-assessed
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/assign @rlobillo |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
1 similar comment
|
/test e2e-openstack-ovn |
1 similar comment
|
e2e-openstack-ovn failed to create a manila share, this is a know issue that was caused by recent CI infra changes. We have a fix at openshift/openstack-test#205 that will need to merge in 4.16. Until then, |
|
@mandre: mandre unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sadasu, could you override |
8 similar comments
|
@mandre: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The fix has merged in 4.16 (openshift/openstack-test#208), and now we expect e2e-openstack-ovn to pass. |
|
@mandre: Jira Issue OCPBUGS-41813: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-41813 has been moved to the MODIFIED state. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: new pull request created: #9294 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
|
Fix included in accepted release 4.16.0-0.nightly-2024-12-11-055812 |
9 participants
This is manual cherry-pick of #8988 and #9081.