Skip to content

[release-4.18] OCPBUGS-46391: node-joiner PXE artifacts should be prefixed "node"#9316

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.18from
openshift-cherrypick-robot:cherry-pick-9280-to-release-4.18
Jan 10, 2025
Merged

[release-4.18] OCPBUGS-46391: node-joiner PXE artifacts should be prefixed "node"#9316
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.18from
openshift-cherrypick-robot:cherry-pick-9280-to-release-4.18

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 13, 2024

This is an automated cherry-pick of #9280

/assign openshift-ci-robot

@rwsu
OCPBUGS-45317: node-joiner PXE artifacts should be prefixed "node"
b93d32c 
instead of "agent".

The "agent" prefix is used for the day 1 agent ISO.

The "node" prefix is used for day-2 artifacts, both ISO and PXE.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 13, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 13, 2024

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-45317 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.18] OCPBUGS-46391: node-joiner PXE artifacts should be prefixed "node"

Details

In response to this:

This is an automated cherry-pick of #9280

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-45317: node-joiner PXE artifacts should be prefixed "node" [release-4.18] OCPBUGS-46391: node-joiner PXE artifacts should be prefixed "node" Dec 13, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 13, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 13, 2024

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-46391, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-45317 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-45317 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #9280

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn b93d32c link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage b93d32c link false /test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/e2e-agent-4control-ipv4 b93d32c link false /test e2e-agent-4control-ipv4
ci/prow/e2e-agent-compact-ipv4-none-platform b93d32c link false /test e2e-agent-compact-ipv4-none-platform

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rwsu
Copy link
Contributor

rwsu commented Jan 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@bfournie
Copy link
Contributor

bfournie commented Jan 9, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 9, 2025
@bmanzari
Copy link

bmanzari commented Jan 9, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 9, 2025
@andfasano
Copy link
Contributor

andfasano commented Jan 9, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3dbc942 into openshift:release-4.18 Jan 10, 2025
19 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 10, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-46391: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-46391 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #9280

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 10, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.18.0-202501100441.p0.g3dbc942.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 10, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.18.0-202501100441.p0.g3dbc942.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 10, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.18.0-202501100441.p0.g3dbc942.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 10, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.18.0-202501100441.p0.g3dbc942.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpei gpei Awaiting requested review from gpei

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

Assignees

@rwsu rwsu

@openshift-ci-robot openshift-ci-robot

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @rwsu @bfournie @bmanzari @andfasano @openshift-bot