CORS-3830: Add missing supported platforms in top-level README#9408
CORS-3830: Add missing supported platforms in top-level README#9408openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
Conversation
|
@tthvo: This pull request references CORS-3830 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @patrickdillon |
patrickdillon
left a comment
There was a problem hiding this comment.
Also can you remove Libvirt? We don't support that any longer either
Yup, make sense! That is now removed in the latest commits. |
|
@tthvo: This pull request references CORS-3830 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@tthvo: This pull request references CORS-3830 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Sorry for potential bikeshedding here, but now that we're in here making changes, I feel like it's a good time to really clean it up--then we can come back in many years :D
So walking back a couple of my earlier suggestions:
- It seems like
Power VSis the more commonly accepted form - The duplication of platforms seems like it could be improved. How about something like this:
- AWS (Official Docs)
- Bare Metal (Official Docs)
- GCP (Official Docs)
and so on...
That is, the anchor text for each platform would take it to the in-repo docs directory (if it exists) and then we have a separate link to official docs (using latest for version in the url).
I know that's a little vague but hopefully makes sense.
That makes sense to me! It looks very much cleaner and has links to official docs now :D |
|
/approve Typically we might want to be more careful with squashing commits, but in this case I think it makes sense to just squash them all, so we can use tide to do that /label tide/merge-method-squash |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tthvo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label acknowledge-critical-fixes-only |
1e5a97e
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
Supported platform list: