Skip to content

CORS-3830: Add missing supported platforms in top-level README#9408

Merged
openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
tthvo:CORS-3830
Jan 29, 2025
Merged

CORS-3830: Add missing supported platforms in top-level README#9408
openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
tthvo:CORS-3830

Conversation

@tthvo
Copy link
Member

@tthvo tthvo commented Jan 27, 2025

Supported platform list:

  • Remove ovirt, libvirt and its documentations (no longer supported).
  • Added ibmcloud, nutanix and powervs

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 27, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 27, 2025

@tthvo: This pull request references CORS-3830 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Supported platform list:

  • Remove ovirt and its documentations (no longer supported).
  • Added ibmcloud, nutanix and powervs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bkhizgiy and rwsu January 27, 2025 19:05
@tthvo
Copy link
Member Author

tthvo commented Jan 27, 2025

/cc @patrickdillon

@openshift-ci openshift-ci bot requested a review from patrickdillon January 27, 2025 19:06
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can you remove Libvirt? We don't support that any longer either

@tthvo
Copy link
Member Author

tthvo commented Jan 28, 2025

Also can you remove Libvirt? We don't support that any longer either

Yup, make sense! That is now removed in the latest commits.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 28, 2025

@tthvo: This pull request references CORS-3830 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Supported platform list:

  • Remove ovirt, libvirt and its documentations (no longer supported).
  • Added ibmcloud, nutanix and powervs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo
Copy link
Member Author

tthvo commented Jan 28, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 28, 2025

@tthvo: This pull request references CORS-3830 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for potential bikeshedding here, but now that we're in here making changes, I feel like it's a good time to really clean it up--then we can come back in many years :D

So walking back a couple of my earlier suggestions:

  1. It seems like Power VS is the more commonly accepted form
  2. The duplication of platforms seems like it could be improved. How about something like this:
  • AWS (Official Docs)
  • Bare Metal (Official Docs)
  • GCP (Official Docs)
    and so on...

That is, the anchor text for each platform would take it to the in-repo docs directory (if it exists) and then we have a separate link to official docs (using latest for version in the url).

I know that's a little vague but hopefully makes sense.

@tthvo
Copy link
Member Author

tthvo commented Jan 28, 2025

That is, the anchor text for each platform would take it to the in-repo docs directory (if it exists) and then we have a separate link to official docs (using latest for version in the url).

That makes sense to me! It looks very much cleaner and has links to official docs now :D

@patrickdillon
Copy link
Contributor

/approve
/lgtm

Typically we might want to be more careful with squashing commits, but in this case I think it makes sense to just squash them all, so we can use tide to do that

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 28, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

@tthvo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-externallb-ovn 9dc14d1 link false /test e2e-vsphere-externallb-ovn
ci/prow/e2e-vsphere-ovn-multi-network 9dc14d1 link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-vsphere-host-groups-ovn-custom-no-upgrade 9dc14d1 link false /test e2e-vsphere-host-groups-ovn-custom-no-upgrade
ci/prow/e2e-azure-ovn-resourcegroup 9dc14d1 link false /test e2e-azure-ovn-resourcegroup

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 29, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 1e5a97e into openshift:main Jan 29, 2025
8 of 12 checks passed
@tthvo tthvo deleted the CORS-3830 branch January 29, 2025 20:50
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202501292227.p0.g1e5a97e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.19.0-202501292227.p0.g1e5a97e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.19.0-202501292227.p0.g1e5a97e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.19.0-202501292227.p0.g1e5a97e.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants