OCPBUGS-54502: ensure ctrplane nodes can access bootstrap MCS#9689
OCPBUGS-54502: ensure ctrplane nodes can access bootstrap MCS#9689openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
When using BYO subnets, users might define subnets in aws.vpc.subnets and define the machineCIDRs in the installconfig from those subnets. Previously, an SG is attached to api lb that only allows ingress to tcp/22623 (MCS) from the only the first machineCIDR, which blocks master nodes from reaching MCS on bootstrap node. This commit adjusts the source for the SG to allow ingress from control plane nodes via SG reference instead of relying on the machineCIDR field.
openshift-ci-robot
added
jira/valid-reference
|
@tthvo: This pull request references Jira Issue OCPBUGS-54502, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@tthvo: This pull request references Jira Issue OCPBUGS-54502, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/test e2e-aws-default-config |
|
openshift/release#64578 for the aws-default-config failure |
|
This change looks good to me and I think it is the best approach to use these node labels. One side-effect, though, is that this would likely require changes to the BYO RHEL host workflow (openshift-ansible), which is no longer supported in 4.19, but something we must consider if we're going to backport this. |
|
/test ? |
|
@patrickdillon: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This may also affect upi. which is probably more relevant than byo rhel host /test e2e-aws-ovn-upi |
|
hm perhaps upi typically already includes the node security group, so maybe we're ok. We'll see what the test says. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
not sure if it is relevant but good to run? /test e2e-aws-upi-proxy |
|
Those extra tests we just launched failed during image build with libvirt 😓 No idea, any pointers? |
|
/lgtm After discussion, my backport concerns are relieved: UPI would (obviously) not have these ingress rules defined so would not be affected; rhel nodes don't pull ignition from the mcs. |
Quickly looking at these logs, these look like CI infrastructure issues to me (rather than a problem in the build configuration). I THINK it's a blip, but let's keep an eye out if we see it in other places. |
|
@tthvo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 7a7c356
into
openshift:main
|
@tthvo: Jira Issue OCPBUGS-54502: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-54502 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
|
/cherry-pick release-4.19 |
|
@tthvo: new pull request created: #9768 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
When using BYO subnets, users might define subnets in aws.vpc.subnets and define the machineCIDRs in the installconfig from those subnets.
Previously, an SG is attached to api lb that only allows ingress to tcp/22623 (MCS) from the only the first machineCIDR, which blocks master nodes from reaching MCS on bootstrap node.
This commit adjusts the source for the SG to allow ingress from control plane nodes via SG reference instead of relying on the machineCIDR field.