SPLAT-2295: Setup additional disks via machine configs#9706
SPLAT-2295: Setup additional disks via machine configs#9706openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
jcpowermac
force-pushed
the
azure-multi-disk
branch
from
6916abf to
68b9f96
Compare
|
|
/test ? |
|
@jcpowermac: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test unit |
1 similar comment
|
/test unit |
jcpowermac
force-pushed
the
azure-multi-disk
branch
from
422a317 to
b9d5e09
Compare
|
/test unit |
jcpowermac
changed the title
|
/test e2e-azure-ovn |
jcpowermac
changed the title
jcpowermac
force-pushed
the
azure-multi-disk
branch
from
6b9a205 to
3a9fcf5
Compare
|
/test e2e-azure-ovn |
|
/test ? |
|
@jcpowermac: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jcpowermac
force-pushed
the
azure-multi-disk
branch
from
3a9fcf5 to
8f60648
Compare
|
/test ? |
|
@jcpowermac: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-azure-ovn-multidisk-techpreview |
jcpowermac
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jcpowermac: This pull request references SPLAT-2295 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jcpowermac: This pull request references SPLAT-2295 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jcpowermac
force-pushed
the
azure-multi-disk
branch
from
453cea1 to
ef0bd5f
Compare
|
/test e2e-azure-ovn-multidisk-techpreview |
|
/test e2e-azure-ovn-multidisk-techpreview |
1 similar comment
|
/test e2e-azure-ovn-multidisk-techpreview |
jcpowermac
force-pushed
the
azure-multi-disk
branch
from
f0c2ef8 to
b7a4cee
Compare
|
/test e2e-azure-ovn-multidisk-techpreview |
|
/test gofmt |
|
/test e2e-azure-ovn-multidisk-techpreview /retest-required |
pablintino
left a comment
pablintino
left a comment
There was a problem hiding this comment.
Looks good to me from an MCO perspective. I dropped some minor cosmetic nits.
jcpowermac
force-pushed
the
azure-multi-disk
branch
2 times, most recently
from
629f780 to
39c1839
Compare
|
/test e2e-azure-ovn-multidisk-techpreview |
| "strings" | ||
| "text/template" | ||
|
|
||
| igntypes "github.com/coreos/ignition/v2/config/v3_2/types" |
There was a problem hiding this comment.
this does remind me we should probably update the installer ignition default type (MCO is using 3.5)
There was a problem hiding this comment.
Just looking at the MC generation and configs, they make sense to me. If there's any edge cases or concerns around the specific partition schema I think we can check with the coreos team.
jcpowermac
force-pushed
the
azure-multi-disk
branch
from
39c1839 to
2f8af04
Compare
Added platform-agnostic multi-disk support using Ignition configuration embedded in MachineConfigs Created new disk types: etcd, swap, and user-defined disks Implemented disk setup validation and feature gates Added machine config generation for disk provisioning Review and unit tests were assisted-by: cursor
jcpowermac
force-pushed
the
azure-multi-disk
branch
from
2f8af04 to
a5c9a11
Compare
|
/test e2e-azure-ovn-multidisk-techpreview |
|
I have been reviewing this and it looks great. There are a few general takeaways, such as updating the ignition version in the installer and refactoring the machine pool validation method to reduce cyclomatic complexity, but those are for the backlog and not this PR. /approve It looks like all of the azure presubmits are failing with some sort of permissions error 🤔 Will take a look. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jcpowermac: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-azure-ovn-multidisk-techpreview |
|
/lgtm |
openshift-merge-bot
bot
merged commit 543865d
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
|
@jcpowermac howdy. do you plan to also use the swap config? For swap we possibly want to enable crypted swap by default, otherwise we risk leaking secrets to disks without knowing. |
11 participants
This PR is part two of the azure changes but also provides changes that other platforms could utilize.
Changes
Main Components:
Platform Implementation:
Additional PRs
Assisted-by: Cursor