Skip to content

CORS-4057: migrate EC2 quota checking code AWS SDK v2#9740

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
tthvo:CORS-4057
Jun 18, 2025
Merged

CORS-4057: migrate EC2 quota checking code AWS SDK v2#9740
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
tthvo:CORS-4057

Conversation

@tthvo
Copy link
Member

@tthvo tthvo commented May 23, 2025

Part of CORS-3819, this focuses on the quote checking code for EC2 instance types.

Note: This only upgrades code for fetching instance types during quota check. Full quote code upgrades to v2 is being tracked in CORS-4061.

Questions: User-provided service endpoints were never considered here. Is this intentional?

Part of CORS-3819, this focuses on the quote checking code for EC2
instance types.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 23, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 23, 2025

@tthvo: This pull request references CORS-4057 which is a valid jira issue.

Details

In response to this:

Part of CORS-3819, this focuses on the quote checking code for EC2 instance types.

Note: This only upgrades code for fetching instance types during quota check. Full quote code upgrades to v2 is being tracked in CORS-4061.

Questions: User-provided service endpoints were never considered here. Is this intentional?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bfournie and mtulio May 23, 2025 00:21
@tthvo
Copy link
Member Author

tthvo commented May 23, 2025

/cc @patrickdillon @barbacbd

@openshift-ci openshift-ci bot requested review from barbacbd and patrickdillon May 23, 2025 00:23
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025
@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 55b3518 and 2 for PR HEAD 9ac0ca4 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 55b3518 and 2 for PR HEAD 9ac0ca4 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2025

@tthvo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-imdsv2 9ac0ca4 link false /test e2e-aws-ovn-imdsv2
ci/prow/okd-scos-e2e-aws-ovn 9ac0ca4 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-multi-network 9ac0ca4 link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-azure-ovn-resourcegroup 9ac0ca4 link false /test e2e-azure-ovn-resourcegroup

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bc941c8 and 1 for PR HEAD 9ac0ca4 in total

@openshift-merge-bot openshift-merge-bot bot merged commit e5574ff into openshift:main Jun 18, 2025
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants