CORS-4054: Migrate from SDK v1 to v2 in installconfig

[barbacbd]

** Update the vendor code to include aws/retry. This package will be
used for throttling error checks.

pkg/asset/installconfig/basedomain.go:

** Use the sdk v2 to check whether the error is a throttle error.

[openshift-ci-robot]

@barbacbd: This pull request references CORS-4054 which is a valid jira issue.

Details

In response to this:

** Update the vendor code to include aws/retry. This package will be
used for throttling error checks.

pkg/asset/installconfig/basedomain.go:

** Use the sdk v2 to check whether the error is a throttle error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[barbacbd]

/cc @tthvo
/cc @patrickdillon

[tthvo]

Looks good! I have some small comments.

I guess ideally we would want to gather these error check into a shared place (not in this PR tho 🤣).

[tthvo]

/lgtm

Nice!

[barbacbd]

/label platform/aws

[patrickdillon]

/approve

This one also needs a rebase...

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node	2994572	link	false	/test e2e-aws-ovn-single-node
ci/prow/e2e-aws-private	2994572	link	false	/test e2e-aws-private
ci/prow/e2e-azure-ovn-resourcegroup	f265dce	link	false	/test e2e-azure-ovn-resourcegroup
ci/prow/e2e-vsphere-ovn-multi-network	f265dce	link	false	/test e2e-vsphere-ovn-multi-network
ci/prow/okd-scos-e2e-aws-ovn	f265dce	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[patrickdillon]

/lgtm

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer
This PR has been included in build ose-installer-container-v4.20.0-202507082342.p0.ga1bfb1c.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.20.0-202507082342.p0.ga1bfb1c.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.20.0-202507082342.p0.ga1bfb1c.assembly.stream.el9.
All builds following this will include this PR.