OCPEDGE-1740: feat: add arbiter role support to ABI#9780
OCPEDGE-1740: feat: add arbiter role support to ABI#9780openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eggfoobar: This pull request references OCPEDGE-1740 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/retest |
data/data/agent/files/usr/local/bin/start-cluster-installation.sh
Outdated
Show resolved
Hide resolved
|
Per Richard's comment, would also need to add a validation to pkg/asset/agent/manifests/agentclusterinstall.go when the number of arbiters is added to AgentClusterInstall. |
eggfoobar
force-pushed
the
support-arbiter-agent-based
branch
from
80974b4 to
f997529
Compare
|
/hold Holding because I hard coded modified the vendor agent cluster install config to test out install until openshift/assisted-service#7765 gets merged in. |
openshift-ci
bot
added
the
do-not-merge/hold
eggfoobar
force-pushed
the
support-arbiter-agent-based
branch
from
f997529 to
36f8417
Compare
openshift-merge-robot
added
the
needs-rebase
eggfoobar
force-pushed
the
support-arbiter-agent-based
branch
from
61d16fd to
f58624d
Compare
openshift-merge-robot
removed
the
needs-rebase
eggfoobar
force-pushed
the
support-arbiter-agent-based
branch
3 times, most recently
from
ca7d026 to
d6d6790
Compare
|
/unhold Hey @rwsu the assisted service api change has been merged in, I went ahead and updated vendor with the new API for |
openshift-ci
bot
removed
the
do-not-merge/hold
eggfoobar
force-pushed
the
support-arbiter-agent-based
branch
2 times, most recently
from
f77450f to
9f2aa11
Compare
|
/retest-required |
|
/retest |
|
/test e2e-agent-4control-ipv4 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rwsu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
andfasano
left a comment
andfasano
left a comment
There was a problem hiding this comment.
Just a minor typo. Note: it would be nice to have the vendoring in a separate commit
updating assisted service api to pull in new ArbiterAgents field for provisioning requirements Signed-off-by: ehila <ehila@redhat.com>
added support for arbiter installs to ABI flow, we currently do not support installing TechPreview featureSet with agent based install, this includes adding that capability for overriding featureSet to be passed to the assisted service. Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
support-arbiter-agent-based
branch
from
9f2aa11 to
75fa733
Compare
| status: | ||
| agentLabelSelector: {} | ||
| bootArtifacts: | ||
| discoveryIgnitionURL: "" |
There was a problem hiding this comment.
I think there was a comment on that but cannot find it anymore, @eggfoobar where is used this field?
There was a problem hiding this comment.
Sure this came along with this addition to the assisted-api, openshift/assisted-service#7243 The default is empty string, so I updated the test to match the new addition
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
@eggfoobar: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 11f646a
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
8 participants
Assisted service now supports the arbiter node, most of the folks looking to use the arbiter node have a low tolerance for extra compute nodes, as such a bootstrap node is not ideal. This PR adds support for the arbiter node to the ABI flow using the latest assisted service additions.
Added support for arbiter installs to ABI flow, we currently do not support installing TechPreview featureSet with agent based install so a temporary override was added for arbiter due to customers who have limitations on running a bootstrap node and will need to run TechPreview installs.