[release-4.19] OCPBUGS-58073: Refactor removing loadbalancer in OpenStack. by openshift-cherrypick-robot · Pull Request #9808 · openshift/installer

openshift-cherrypick-robot · 2025-06-25T07:09:38Z

This is an automated cherry-pick of #9724

/assign gryf

/cherrypick release-4.18 release-4.17 release-4.16 release-4.15 release-4.14

Currently, the approach for removing OpenStack loadbalancers is to look for appropriate tag (i.e. openshiftClusterID=<cluster_id>) and then delete it. Issue with this approach is that no such tags are applied on the loadbalancer resources, and also there is no such tag in description field. Hence, deleteLoadBalancer function will give 0 results for existing loadbalancers, as they have no such tag either in tags nor on description. With this patch, deleteLoadBalancer has been refactored to get all the loadbalancers and filter out that resources which have ClusterID in description, so that they will be safely deleted.

openshift-ci-robot · 2025-06-25T07:10:56Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-18510 has been cloned as Jira Issue OCPBUGS-58073. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-58073: Refactor removing loadbalancer in OpenStack.

Details

In response to this:

This is an automated cherry-pick of #9724

/assign gryf

/cherrypick release-4.18 release-4.17 release-4.16 release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-06-25T07:11:15Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-58073, which is invalid:

expected dependent Jira Issue OCPBUGS-18510 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #9724

/assign gryf

/cherrypick release-4.18 release-4.17 release-4.16 release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tthvo

/approve

openshift-ci · 2025-06-26T18:58:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [tthvo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gryf · 2025-07-02T06:44:39Z

/jira refresh

openshift-ci-robot · 2025-07-02T06:44:45Z

@gryf: An error was encountered updating to the POST state for bug OCPBUGS-58073 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


It seems that you have tried to perform a workflow operation (POST) that is not valid for the current state of this issue (OCPBUGS-58073). The likely cause is that somebody has changed the issue recently, please look at the issue history for details.: request failed. Please analyze the request body for more details. Status code: 400:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gryf · 2025-07-02T06:46:50Z

/jira refresh

openshift-ci-robot · 2025-07-02T06:46:57Z

@gryf: This pull request references Jira Issue OCPBUGS-58073, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-18510 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-18510 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2025-07-03T13:17:44Z

/lgtm

sadasu · 2025-07-03T13:17:53Z

/label backport-risk-assessed

tthvo · 2025-07-03T16:25:03Z

/cc @gpei

gpei · 2025-07-04T00:06:07Z

/label cherry-pick-approved

openshift-ci-robot · 2025-07-04T01:27:43Z

/retest-required

Remaining retests: 0 against base HEAD 5916c39 and 2 for PR HEAD fe679c0 in total

gryf · 2025-07-04T08:30:30Z

/retest-required

openshift-ci-robot · 2025-07-04T11:41:37Z

/retest-required

Remaining retests: 0 against base HEAD 5916c39 and 2 for PR HEAD fe679c0 in total

openshift-ci · 2025-07-04T15:18:18Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-multi-network	`fe679c0`	link	false	`/test e2e-vsphere-ovn-multi-network`
ci/prow/okd-scos-e2e-aws-ovn	`fe679c0`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-openstack-proxy	`fe679c0`	link	false	`/test e2e-openstack-proxy`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-07-04T15:51:00Z

/retest-required

Remaining retests: 0 against base HEAD 5916c39 and 2 for PR HEAD fe679c0 in total

openshift-ci-robot · 2025-07-04T19:18:17Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-58073: All pull requests linked via external trackers have merged:

openshift/installer#9808

Jira Issue OCPBUGS-58073 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #9724

/assign gryf

/cherrypick release-4.18 release-4.17 release-4.16 release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-07-04T19:20:10Z

@openshift-cherrypick-robot: #9808 failed to apply on top of branch "release-4.18":

Applying: Refactor removing loadbalancer in OpenStack.
Using index info to reconstruct a base tree...
M	vendor/github.com/gophercloud/gophercloud/v2/openstack/loadbalancer/v2/apiversions/results.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Removing vendor/github.com/gophercloud/gophercloud/v2/openstack/loadbalancer/v2/apiversions/urls.go
CONFLICT (modify/delete): vendor/github.com/gophercloud/gophercloud/v2/openstack/loadbalancer/v2/apiversions/results.go deleted in Refactor removing loadbalancer in OpenStack. and modified in HEAD. Version HEAD of vendor/github.com/gophercloud/gophercloud/v2/openstack/loadbalancer/v2/apiversions/results.go left in tree.
Removing vendor/github.com/gophercloud/gophercloud/v2/openstack/loadbalancer/v2/apiversions/requests.go
Removing vendor/github.com/gophercloud/gophercloud/v2/openstack/loadbalancer/v2/apiversions/doc.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Refactor removing loadbalancer in OpenStack.

Details

In response to this:

This is an automated cherry-pick of #9724

/assign gryf

/cherrypick release-4.18 release-4.17 release-4.16 release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2025-07-04T21:01:15Z

[ART PR BUILD NOTIFIER]

Distgit: ose-installer
This PR has been included in build ose-installer-container-v4.19.0-202507041937.p0.gc2a0bea.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2025-07-04T21:13:16Z

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.19.0-202507041937.p0.gc2a0bea.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2025-07-05T00:46:14Z

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.19.0-202507042236.p0.gc2a0bea.assembly.stream.el9.
All builds following this will include this PR.

openshift-merge-robot · 2025-07-09T01:43:27Z

Fix included in accepted release 4.19.0-0.nightly-2025-07-08-172809

openshift-cherrypick-robot assigned gryf Jun 25, 2025

openshift-cherrypick-robot mentioned this pull request Jun 25, 2025

OCPBUGS-18510: Refactor removing loadbalancer in OpenStack. #9724

Merged

openshift-ci bot changed the title ~~[release-4.19] OCPBUGS-18510: Refactor removing loadbalancer in OpenStack.~~ [release-4.19] OCPBUGS-58073: Refactor removing loadbalancer in OpenStack. Jun 25, 2025

openshift-ci bot requested review from barbacbd and mdbooth June 25, 2025 07:11

tthvo reviewed Jun 26, 2025

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 2, 2025

openshift-ci bot assigned sadasu Jul 3, 2025

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jul 3, 2025

openshift-ci bot requested a review from gpei July 3, 2025 16:25

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 4, 2025

openshift-merge-bot bot merged commit c2a0bea into openshift:release-4.19 Jul 4, 2025
22 of 25 checks passed

Conversation

openshift-cherrypick-robot commented Jun 25, 2025

Uh oh!

openshift-ci-robot commented Jun 25, 2025

Uh oh!

openshift-ci-robot commented Jun 25, 2025

Uh oh!

tthvo left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jun 26, 2025

Uh oh!

gryf commented Jul 2, 2025

Uh oh!

openshift-ci-robot commented Jul 2, 2025

Uh oh!

gryf commented Jul 2, 2025

Uh oh!

openshift-ci-robot commented Jul 2, 2025

Uh oh!

sadasu commented Jul 3, 2025

Uh oh!

sadasu commented Jul 3, 2025

Uh oh!

tthvo commented Jul 3, 2025

Uh oh!

gpei commented Jul 4, 2025

Uh oh!

openshift-ci-robot commented Jul 4, 2025

Uh oh!

gryf commented Jul 4, 2025

Uh oh!

openshift-ci-robot commented Jul 4, 2025

Uh oh!

openshift-ci bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 4, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 4, 2025

Uh oh!

openshift-cherrypick-robot commented Jul 4, 2025

Uh oh!

openshift-bot commented Jul 4, 2025

Uh oh!

openshift-bot commented Jul 4, 2025

Uh oh!

openshift-bot commented Jul 5, 2025

Uh oh!

openshift-merge-robot commented Jul 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

openshift-ci bot commented Jul 4, 2025 •

edited

Loading