Skip to content

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Nov 18, 2025

prerequisite openshift/release#71583 to fix the failing verify test

k8s-release-robot and others added 22 commits September 9, 2025 23:19
…rry-pick-of-#133953-upstream-release-1.31

Automated cherry pick of kubernetes#133953: Fix ClusterIP load balancer disappearing when InternalTrafficPolicy: Local is set.
…ck-of-#134588-upstream-release-1.31

Automated cherry pick of kubernetes#134588: go 1.25.2/1.24.8 related fixes
These suppressions are necessary to make golangci-lint 1.64 pass with the
current code base. This change is meant to be backported to release
branches. On master, we may want to revert some of it together with fixing the
findings.
…he code base

Fixes issues in https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/134594/pull-kubernetes-verify/1978153763923300352

These were cleaned up in 1.32:
* PR 127534 (kubectl contains)
* PR 127535 (client-go contains)
* PR 127529 (apiserver negative-positive)
* PR 127536 (apiserver contains)
* PR 127527 (client-go negative-positive)

Exempting these stricter checks from the release branch checks to minimize code churn
Manual partial cherry-pick of lint changes from kubernetes#129688 to release-1.31 for Go 1.24 bump
…ss iptables

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
[release-1.31][go] Bump dependencies, images and versions used to Go 1.24.9 and distroless iptables
Signed-off-by: joshjms <joshjms1607@gmail.com>
…k-of-#134268-upstream-release-1.31

Automated cherry pick of kubernetes#134268: gce: Fix etcd manifest
Signed-off-by: joshjms <joshjms1607@gmail.com>
…k-of-#134861-upstream-release-1.31

Automated cherry pick of kubernetes#134861: [release-1.34] etcd: Bump supported etcd version to v3.5.24 for release v1.31, v1.32, and v1.33
Kubernetes official release v1.31.14
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 18, 2025
@openshift-ci-robot
Copy link

@atiratree: This pull request references Jira Issue OCPBUGS-65553, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-65553 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@atiratree: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and tkashem November 18, 2025 13:04
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Nov 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jacobsee
Copy link
Member

/retest-required

@openshift-ci-robot
Copy link

@atiratree: This pull request references Jira Issue OCPBUGS-65553, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-65553 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

prerequisite openshift/release#71583 to fix the failing verify test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@atiratree
Copy link
Member Author

/hold

@jacobsee FYI we have to merge openshift/release#71583 first to fix the failing verify test

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2025

@atiratree: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify b10f2cc link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.