-
Notifications
You must be signed in to change notification settings - Fork 34
Bug 2090809: clock class parsing error fix #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2090809: clock class parsing error fix #81
Conversation
while parsing value for gm.Clockclass, the logic was parsing every string from findSubstring slice The fix avoids false error and parses only the matched value from the regex Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aneeshkp, josephdrichard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@aneeshkp: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retitle Bug 2090809: clock class parsing error fix |
|
@aneeshkp: This pull request references Bugzilla bug 2090809, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@aneeshkp: This pull request references Bugzilla bug 2090809, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (obochan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@aneeshkp: All pull requests linked via external trackers have merged: Bugzilla bug 2090809 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bug 2090809: clock class parsing error fix Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com>
Stop reporting unhandled roles as errors
while parsing value for gm.Clockclass, the logic was parsing every string from findSubstring slice
The fix avoids false error and parses only the matched value from the regex
Signed-off-by: Aneesh Puttur aneeshputtur@gmail.com