Skip to content

Conversation

@aneeshkp
Copy link
Contributor

while parsing value for gm.Clockclass, the logic was parsing every string from findSubstring slice
The fix avoids false error and parses only the matched value from the regex
Signed-off-by: Aneesh Puttur aneeshputtur@gmail.com

@openshift-ci openshift-ci bot requested review from SchSeba and fepan May 26, 2022 15:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
while parsing value for gm.Clockclass, the logic was parsing every string from findSubstring slice
The fix avoids false error and parses only the matched value from the regex
Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com>
@josephdrichard
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, josephdrichard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aneeshkp,josephdrichard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@aneeshkp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aneeshkp
Copy link
Contributor Author

/retitle Bug 2090809: clock class parsing error fix

@openshift-ci openshift-ci bot changed the title Bug 2090809 :clock class parsing error fix Bug 2090809: clock class parsing error fix May 27, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@aneeshkp: This pull request references Bugzilla bug 2090809, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2090809: clock class parsing error fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aneeshkp
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels May 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@aneeshkp: This pull request references Bugzilla bug 2090809, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (obochan@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8a9f7b8 into openshift:master May 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@aneeshkp: All pull requests linked via external trackers have merged:

Bugzilla bug 2090809 has been moved to the MODIFIED state.

In response to this:

Bug 2090809: clock class parsing error fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aneeshkp pushed a commit to aneeshkp/linuxptp-daemon that referenced this pull request Aug 18, 2022
Bug 2090809: clock class parsing error fix

Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com>
josephdrichard pushed a commit to josephdrichard/linuxptp-daemon that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants