Skip to content

Conversation

@jgbernalp
Copy link
Contributor

@jgbernalp jgbernalp commented May 9, 2025

Fixes:

Notable changes:

  • @zhuje added the parsing of new otel labels and attributes, and the schema dropdown
  • Created a new useLogsConfig hook and provider to share the same config across components and hooks, pages are now wrapped with this provider
  • Added the schema configuration to the backend plugin config
  • Removed the logs_type matcher if there are other matchers: OU-313
  • As initial queries and attributes depend on the selected/configured schema, the useURLState hook now accepts initializer functions for these values
  • When changing the schema the current query is updated to match the correct model labels

UX:
Added the schema dropdown, visible only when the config.schema is set to "select"

Pod detail
Screenshot 2025-05-09 at 10 30 54

Dev perspective
Screenshot 2025-05-09 at 10 30 31

Admin perspective
Screenshot 2025-05-09 at 10 29 37

Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2025
@jgbernalp jgbernalp requested a review from PeterYurkovich May 9, 2025 08:23
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2025

@jgbernalp: This pull request references OU-731 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Fixes:

Notable changes:

  • @zhuje added the parsing of new otel labels and attributes, and the schema dropdown
  • Created a new useLogsConfig hook and provider to share the same config across components and hooks, pages are now wrapped with this provider
  • Added the schema configuration to the backend plugin config
  • Removed the logs_type matcher if there are other matchers: OU-313
  • As initial queries and attributes depend on the selected/configured schema, the useURLState hook now accepts initializer functions for these values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from kyoto and zhuje May 9, 2025 08:23
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2025

@jgbernalp: This pull request references OU-731 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Fixes:

Notable changes:

  • @zhuje added the parsing of new otel labels and attributes, and the schema dropdown
  • Created a new useLogsConfig hook and provider to share the same config across components and hooks, pages are now wrapped with this provider
  • Added the schema configuration to the backend plugin config
  • Removed the logs_type matcher if there are other matchers: OU-313
  • As initial queries and attributes depend on the selected/configured schema, the useURLState hook now accepts initializer functions for these values
  • When changing the schema the current query is updated to match the correct model labels

UX:
Added the schema dropdown, visible only when the config.schema is set to "select"

Pod detail
Screenshot 2025-05-09 at 10 30 54

Dev perspective
Screenshot 2025-05-09 at 10 30 31

Admin perspective
Screenshot 2025-05-09 at 10 29 37

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2025

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@PeterYurkovich
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgbernalp
Copy link
Contributor Author

cc @fkargbo

@jgbernalp
Copy link
Contributor Author

/label qe-approved
will be tested along with COO changes

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 10, 2025

@jgbernalp: This pull request references OU-731 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Fixes:

Notable changes:

  • @zhuje added the parsing of new otel labels and attributes, and the schema dropdown
  • Created a new useLogsConfig hook and provider to share the same config across components and hooks, pages are now wrapped with this provider
  • Added the schema configuration to the backend plugin config
  • Removed the logs_type matcher if there are other matchers: OU-313
  • As initial queries and attributes depend on the selected/configured schema, the useURLState hook now accepts initializer functions for these values
  • When changing the schema the current query is updated to match the correct model labels

UX:
Added the schema dropdown, visible only when the config.schema is set to "select"

Pod detail
Screenshot 2025-05-09 at 10 30 54

Dev perspective
Screenshot 2025-05-09 at 10 30 31

Admin perspective
Screenshot 2025-05-09 at 10 29 37

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fkargbo
Copy link

fkargbo commented May 11, 2025

/label ux-approved

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label May 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 15b1123 into openshift:main May 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants