Skip to content

SPLAT-2526: Refactor openshift-tests-ext #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

SPLAT-2526: Refactor openshift-tests-ext #1423

merged 2 commits into from
Oct 30, 2025

Conversation

@vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Oct 23, 2025 •
edited by openshift-ci bot
Loading

SPLAT-2526

Changes

  • Moved openshift-tests-ext to its own inner project to reduce complexity to operator's go.mod dependencies

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 23, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2526 which is a valid jira issue.

In response to this:

SPLAT-2526

Changes

  • Moved openshift-tests-ext to its own inner project to reduce complexity to operator's go.mod dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2526 which is a valid jira issue.

In response to this:

SPLAT-2526

Changes

  • Moved openshift-tests-ext to its own inner project to reduce complexity to operator's go.mod dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from chrischdi and damdo October 23, 2025 11:50
@vr4manta
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/04784dc0-b00a-11f0-9ea3-21e27d215dc7-0

damdo
damdo reviewed Oct 23, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@damdo
Copy link
Member

damdo commented Oct 23, 2025

/assign @mdbooth @JoelSpeed

@theobarberbany
Copy link
Contributor

/lgtm

makes sense to me

@nrb
Copy link
Contributor

nrb commented Oct 23, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2025
@damdo
Copy link
Member

damdo commented Oct 23, 2025

/retest-required

2 similar comments
@damdo
Copy link
Member

damdo commented Oct 24, 2025

/retest-required

@vr4manta
Copy link
Contributor Author

/retest-required

@chrischdi
Copy link
Contributor

chrischdi commented Oct 28, 2025 •
edited
Loading

Shouldn't we add the new directory to be handled in: hack/go-mod.sh and to the generate-modules + verify-modules make target?

@chrischdi
Copy link
Contributor

/hold

For the above.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2025
@vr4manta vr4manta force-pushed the refactor-openshift-ext branch from 3e71bd0 to bae7ab8 Compare October 28, 2025 13:08
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025
@vr4manta
Copy link
Contributor Author

vr4manta commented Oct 28, 2025 •
edited
Loading

Shouldn't we add the new directory to be handled in: hack/go-mod.sh and to the generate-modules + verify-modules make target?

@chrischdi I have updated the go-mod.sh file to perform on OTE. Can you explain the second issue of generate-modules + verify-modules? I am not seeing that target in the make file.

@chrischdi
Copy link
Contributor

Shouldn't we add the new directory to be handled in: hack/go-mod.sh and to the generate-modules + verify-modules make target?

@chrischdi I have updated the go-mod.sh file to perform on OTE. Can you explain the second issue of generate-modules + verify-modules? I am not seeing that target in the make file.

My bad, looks like I did browse the wrong repo 👍

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

@damdo: The following commands are available to trigger required jobs:

/test e2e-aws-operator

/test e2e-aws-ovn

/test e2e-aws-ovn-upgrade

/test e2e-metal-ipi

/test e2e-metal-ipi-ovn-ipv6

/test e2e-metal-ipi-virtualmedia

/test goimports

/test golint

/test govet

/test images

/test okd-scos-images

/test unit

/test verify-crds-sync

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-aws-operator-techpreview

/test e2e-azure-manual-oidc

/test e2e-azure-operator

/test e2e-azure-ovn

/test e2e-gcp-operator

/test e2e-gcp-ovn

/test e2e-metal-ipi-ovn-dualstack

/test e2e-metal-ipi-upgrade

/test e2e-nutanix

/test e2e-openstack

/test e2e-vsphere-host-groups-ovn-techpreview

/test e2e-vsphere-operator

/test e2e-vsphere-ovn

/test e2e-vsphere-ovn-multi-vcenter

/test e2e-vsphere-ovn-serial

/test e2e-vsphere-ovn-techpreview

/test e2e-vsphere-ovn-techpreview-serial

/test e2e-vsphere-ovn-upgrade

/test e2e-vsphere-static-ovn

/test okd-scos-e2e-aws-ovn

/test regression-clusterinfra-aws-ipi-mapi

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-machine-api-operator-main-e2e-aws-operator

pull-ci-openshift-machine-api-operator-main-e2e-aws-ovn

pull-ci-openshift-machine-api-operator-main-e2e-aws-ovn-upgrade

pull-ci-openshift-machine-api-operator-main-e2e-metal-ipi

pull-ci-openshift-machine-api-operator-main-e2e-metal-ipi-ovn-ipv6

pull-ci-openshift-machine-api-operator-main-e2e-metal-ipi-virtualmedia

pull-ci-openshift-machine-api-operator-main-goimports

pull-ci-openshift-machine-api-operator-main-golint

pull-ci-openshift-machine-api-operator-main-govet

pull-ci-openshift-machine-api-operator-main-images

pull-ci-openshift-machine-api-operator-main-okd-scos-e2e-aws-ovn

pull-ci-openshift-machine-api-operator-main-okd-scos-images

pull-ci-openshift-machine-api-operator-main-regression-clusterinfra-aws-ipi-mapi

pull-ci-openshift-machine-api-operator-main-unit

pull-ci-openshift-machine-api-operator-main-verify-crds-sync

pull-ci-openshift-machine-api-operator-main-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo
Copy link
Member

damdo commented Oct 28, 2025

/hold

For testing to finish

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2025
@damdo
Copy link
Member

damdo commented Oct 28, 2025

//test e2e-aws-ovn

@vr4manta
Copy link
Contributor Author

/test e2e-vsphere-ovn e2e-aws-ovn

@damdo
Copy link
Member

damdo commented Oct 28, 2025

/retest-required

@damdo
Copy link
Member

damdo commented Oct 29, 2025

/test e2e-vsphere-ovn

@damdo
Copy link
Member

damdo commented Oct 29, 2025

/retest-required

@damdo
Copy link
Member

damdo commented Oct 29, 2025

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

@damdo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/07753020-b496-11f0-81b1-9703853f883b-0

@damdo
Copy link
Member

damdo commented Oct 29, 2025

/skip

@damdo
Copy link
Member

damdo commented Oct 29, 2025

/test e2e-aws-ovn

4 similar comments
@damdo
Copy link
Member

damdo commented Oct 29, 2025

/test e2e-aws-ovn

@damdo
Copy link
Member

damdo commented Oct 29, 2025

/test e2e-aws-ovn

@damdo
Copy link
Member

damdo commented Oct 29, 2025

/test e2e-aws-ovn

@damdo
Copy link
Member

damdo commented Oct 30, 2025

/test e2e-aws-ovn

@damdo
Copy link
Member

damdo commented Oct 30, 2025

/override ci/prow/e2e-aws-ovn

Failures are unrelated to this binary move/change

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

Failures are unrelated to this binary move/change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo
Copy link
Member

damdo commented Oct 30, 2025

/verified by seeing OTE MAO has run in https://pr-payload-tests.ci.openshift.org/runs/ci/07753020-b496-11f0-81b1-9703853f883b-0

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 30, 2025
@damdo
Copy link
Member

damdo commented Oct 30, 2025

/unhold

@openshift-ci-robot
Copy link
Contributor

@damdo: This PR has been marked as verified by seeing OTE MAO has run in https://pr-payload-tests.ci.openshift.org/runs/ci/07753020-b496-11f0-81b1-9703853f883b-0.

In response to this:

/verified by seeing OTE MAO has run in https://pr-payload-tests.ci.openshift.org/runs/ci/07753020-b496-11f0-81b1-9703853f883b-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2488b27 and 2 for PR HEAD bae7ab8 in total

@damdo
Copy link
Member

damdo commented Oct 30, 2025

/override ci/prow/e2e-metal-ipi ci/prow/e2e-metal-ipi-ovn-ipv6 ci/prow/e2e-metal-ipi-virtualmedia

The OTE moving doesn't affect the metal jobs, which are failing due to unrelated issues. Overriding..

@openshift openshift deleted a comment from openshift-ci bot Oct 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025 •
edited
Loading

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn bae7ab8 link false /test okd-scos-e2e-aws-ovn
ci/prow/regression-clusterinfra-aws-ipi-mapi bae7ab8 link false /test regression-clusterinfra-aws-ipi-mapi
ci/prow/e2e-vsphere-ovn bae7ab8 link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-metal-ipi, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-virtualmedia

In response to this:

/override ci/prow/e2e-metal-ipi ci/prow/e2e-metal-ipi-ovn-ipv6 ci/prow/e2e-metal-ipi-virtualmedia

The OTE moving doesn't affect the metal jobs, which are failing due to unrelated issues. Overriding..

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 23228bb into openshift:main Oct 30, 2025
19 checks passed
@neisw neisw mentioned this pull request Oct 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

@mdbooth mdbooth

@damdo damdo

@JoelSpeed JoelSpeed

@theobarberbany theobarberbany

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@vr4manta @openshift-ci-robot @damdo @theobarberbany @nrb @chrischdi @mdbooth @JoelSpeed