Fix VSphereMultiNetworks tests failing with 'cannot clone suite after… #1433
Conversation
… tree has been built' After bumping to k8s 1.34 (commit dd24836), which updated ginkgo/v2 from v2.23.4 to v2.27.2, all VSphereMultiNetworks tests began failing immediately with the error "cannot clone suite after tree has been built". Root cause: The newer Ginkgo version enforces stricter checks preventing suite cloning after the tree has been built. When tests run in parallel, child processes are spawned with the "run-test" command, which re-enters main() and calls BuildExtensionTestSpecsFromOpenShiftGinkgoSuite() again, rebuilding the Ginkgo suite tree. When the child process attempts to run the test, Ginkgo's RunSpecs() calls PushClone() which fails because the tree was already built. Solution: Only build the Ginkgo test specs when NOT in "run-test" mode. This prevents child processes from rebuilding the suite tree, allowing the clone operation to succeed during parallel test execution. Co-Authored-By: Claude <noreply@anthropic.com>
|
/test ? |
|
@jcpowermac: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-vsphere-ovn |
|
/test unit |
|
@jcpowermac: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
… tree has been built'
After bumping to k8s 1.34 (commit dd24836), which updated ginkgo/v2 from v2.23.4 to v2.27.2, all VSphereMultiNetworks tests began failing immediately with the error "cannot clone suite after tree has been built".
Root cause: The newer Ginkgo version enforces stricter checks preventing suite cloning after the tree has been built. When tests run in parallel, child processes are spawned with the "run-test" command, which re-enters main() and calls BuildExtensionTestSpecsFromOpenShiftGinkgoSuite() again, rebuilding the Ginkgo suite tree. When the child process attempts to run the test, Ginkgo's RunSpecs() calls PushClone() which fails because the tree was already built.
Solution: Only build the Ginkgo test specs when NOT in "run-test" mode. This prevents child processes from rebuilding the suite tree, allowing the clone operation to succeed during parallel test execution.
🤖 Generated with Claude Code