OCPCLOUD-3268: Update cluster-api to v1.11.3 #1438
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@dlom: This pull request references OCPCLOUD-3268 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| "k8s.io/component-base/featuregate" | ||
| "k8s.io/klog/v2" | ||
| ipamv1beta1 "sigs.k8s.io/cluster-api/exp/ipam/api/v1beta1" | ||
| ipamv1beta1 "sigs.k8s.io/cluster-api/api/ipam/v1beta1" //nolint:staticcheck |
There was a problem hiding this comment.
Why nolint? What's the report here?
There was a problem hiding this comment.
SA1019: "sigs.k8s.io/cluster-api/api/ipam/v1beta1" is deprecated: This package is deprecated and is going to be removed when support for v1beta1 will be dropped. (staticcheck)
I copied these from the installer: openshift/installer@1071658
|
/retest-required |
|
/jira refresh |
|
@dlom: This pull request references OCPCLOUD-3268 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@dlom: This pull request references OCPCLOUD-3268 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
I can't tell if these failures are flakes or not /retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
@dlom: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@JoelSpeed can you tag this as verified please? |
4 participants
Hive has code dependencies on both the
installerand themachine-api-operator, and both projects have code dependencies oncluster-api. Thecluster-apimade some very backwards incompatible changes, so it must be updated here as wellxref: OCPCLOUD-3268
/cc @2uasimojo