-
Notifications
You must be signed in to change notification settings - Fork 226
Add CLI printer columns for machine, machinesets #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI printer columns for machine, machinesets #176
Conversation
It is inevitable that you will want printers for each provider. The beta is targeting AWS, so this is good for now. As we surface other providers, we may want to look at having the machine-api-operator itself install the CRDs that vary by provider so we can have pretty columns rendered with platform specific metadata. We should do the same for machinedeployments. When we support machine class, we want to revisit this. |
8efeeef
to
206ffae
Compare
I hate machinesets columns (which are really deployment columns) but it's fine. I have open bugs upstream to make them not suck, but it's not your problem |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks! I added a commit on your branch to make yaml lint happy |
/test e2e-aws |
Would be great to have a clean way to do that.
As long as the CRDs are again managed by the machine-api-operator, it is acceptable. Though, it will cause troubles when (and if) we start supporting multiple instances of an actuator inside the same cluster (a.k.a hybrid clouds). |
/lgtm /retest |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
Record update events as well
This adds pretty printers when rendering tables in CLI.
Machines
MachineSets