Skip to content

Conversation

@enxebre
Copy link
Member

@enxebre enxebre commented Aug 7, 2019

Watch MachineHealthChecks and enqueue reconcile.Request for the backed nodes.
This is useful to trigger remediation when e.g a machineHealCheck is created against
a node which is already unhealthy and is not able to receive status updates which would otherwise be ignored by MHC
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1704587

@openshift-ci-robot
Copy link
Contributor

@enxebre: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1704587: Reconcile nodes on MHC changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 7, 2019
@openshift-ci-robot
Copy link
Contributor

@enxebre: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1704587: Reconcile nodes on MHC changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2019
@frobware
Copy link
Contributor

frobware commented Aug 7, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@openshift-merge-robot openshift-merge-robot merged commit fecb4a7 into openshift:master Aug 7, 2019
@openshift-ci-robot
Copy link
Contributor

@enxebre: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

In response to this:

Bug 1704587: Reconcile nodes on MHC changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants