Skip to content

Bug 2037484: Dep bump #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2022
Merged

Bug 2037484: Dep bump #11

merged 3 commits into from
Jan 7, 2022

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Dec 10, 2021 •
edited
Loading

This PR contains two commits:

  • Update test tooling. Bumps ginkgo and gomega
  • Remove a dependency on klog v1 replacing it with klog v2

Deferring any further dependency bump until after:

@openshift-ci openshift-ci bot requested a review from mandre December 10, 2021 10:54
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from mdbooth December 10, 2021 10:54
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2021
@pierreprinetti
Copy link
Member Author 

level=fatal msg=failed to initialize the cluster: Some cluster operators are still updating: authentication, console

/retest

mandre
mandre reviewed Dec 12, 2021
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2021
@pierreprinetti
Copy link
Member Author

This is ready for a review.

@pierreprinetti
Copy link
Member Author

/retest

pierreprinetti and others added 3 commits January 7, 2022 10:02
@pierreprinetti @mandre
Dependency update: logging
e7750b9 
Remove a dependency on klog v1
@pierreprinetti @mandre
Dependency update: test tooling
7dde41e 
Bump ginkgo and gomega to their latest versions
@mandre
Bump k8s to 1.23
19f61f4 
This is the result of:
```
go get github.com/openshift/api@7c47a5f
go get github.com/openshift/client-go@7385dd6
go get github.com/openshift/machine-api-operator@7ba373c
go get k8s.io/cluster-bootstrap@c210078
go mod vendor
go mod tidy
```
@mandre mandre changed the title Dep bump Bug 2037484: Dep bump Jan 7, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2022

@pierreprinetti: This pull request references Bugzilla bug 2037484, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2037484: Dep bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Jan 7, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2022

@mandre: This pull request references Bugzilla bug 2037484, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Jan 7, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2022

@mandre: This pull request references Bugzilla bug 2037484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from eurijon January 7, 2022 09:44
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2022

@pierreprinetti: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 19f61f4 link false /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@iamemilio
Copy link
Contributor

/lgtm
the e2e test is down right now

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit 2401f74 into openshift:master Jan 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2022

@pierreprinetti: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2037484 has not been moved to the MODIFIED state.

In response to this:

Bug 2037484: Dep bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the dep_bump branch January 7, 2022 15:11
@openshift-ci openshift-ci bot mentioned this pull request Jan 12, 2022
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-api-provider-openstack-container-v4.10.0-202305011254.p0.g2401f74.assembly.stream for distgit ose-machine-api-provider-openstack.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

@mdbooth mdbooth Awaiting requested review from mdbooth

@eurijon eurijon Awaiting requested review from eurijon

Assignees

@iamemilio iamemilio

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pierreprinetti @mandre @iamemilio @openshift-bot @openshift-merge-robot