Skip to content

Conversation

@retroflexer
Copy link

Closes: #1770269
- What I did
Added etcdctl version in usr-local-bin-openshift-recovery-tools-sh.yaml
- How to verify it
Verify that the DR scripts of release 4.3 use etcdctl of version v3.3.17
- Description for the changelog

The DR scripts download the etcdctl on-demand, but the version was set in various scripts to an older version. This change sets the ETCD_VERSION in one place, and removes all the older versions from the other places.

@openshift-ci-robot
Copy link
Contributor

@retroflexer: This pull request references Bugzilla bug 1770269, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1770269: DR: etcdctl version should match with what is shipped with product

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2019
@runcom
Copy link
Member

runcom commented Nov 19, 2019

@hexfusion ptal

Copy link
Contributor

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the system is upgraded and had done DR in past we will overwrite old version of client.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2019
@runcom
Copy link
Member

runcom commented Nov 19, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, retroflexer, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2019
@openshift-merge-robot openshift-merge-robot merged commit 47c32dc into openshift:master Nov 19, 2019
@openshift-ci-robot
Copy link
Contributor

@retroflexer: All pull requests linked via external trackers have merged. Bugzilla bug 1770269 has been moved to the MODIFIED state.

In response to this:

Bug 1770269: DR: etcdctl version should match with what is shipped with product

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@retroflexer retroflexer deleted the bz-1770269-etcdctl-version-should-match branch January 31, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants