Skip to content

Conversation

@LorbusChris
Copy link
Contributor

Setting reason to error message can cause Prometheus to report too many series and can potentially bring it down completely.
This patch adds a reason constant to fix the above.

This will be followed up with the addition of more reason constants.

Setting reason to error message can cause Prometheus to report too many series and can potentially bring it down completely. This patch adds a reason constant to fix the above.
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 21, 2019
@openshift-ci-robot
Copy link
Contributor

@LorbusChris: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1722894: pkg/operator: Add FailedToSync Reason

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2019
@runcom
Copy link
Member

runcom commented Jun 21, 2019

/cherrypick release-4.1

@openshift-cherrypick-robot

@runcom: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom
Copy link
Member

runcom commented Jun 21, 2019

4.1.z BZ is here https://bugzilla.redhat.com/show_bug.cgi?id=1722887 - Christian's going to reference it in the backport PR as well.

@runcom
Copy link
Member

runcom commented Jun 21, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2019
@runcom
Copy link
Member

runcom commented Jun 21, 2019

/retest

@cgwalters
Copy link
Member

/approve
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, LorbusChris, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LorbusChris,cgwalters,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot

@runcom: new pull request created: #879

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris LorbusChris deleted the fix-reason branch June 23, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants