-
Notifications
You must be signed in to change notification settings - Fork 458
Bug 1722894: pkg/operator: Add FailedToSync Reason #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1722894: pkg/operator: Add FailedToSync Reason #876
Conversation
Setting reason to error message can cause Prometheus to report too many series and can potentially bring it down completely. This patch adds a reason constant to fix the above.
|
@LorbusChris: This pull request references a valid Bugzilla bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.1 |
|
@runcom: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
4.1.z BZ is here https://bugzilla.redhat.com/show_bug.cgi?id=1722887 - Christian's going to reference it in the backport PR as well. |
|
/approve |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, LorbusChris, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@runcom: new pull request created: #879 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Setting reason to error message can cause Prometheus to report too many series and can potentially bring it down completely.
This patch adds a reason constant to fix the above.
This will be followed up with the addition of more reason constants.