OSD-6482: Dedicated-admins should be able to manage CustomDomain #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow `CustomDomain` objects from `managed.openshift.io` to be managed by members of the dedicated-admins group. This will also slightly modify the logic of the `MustGather` section to refer to the ApiGroup as well as the Kind (for future safety), and switch them to being references to constants. Further, the check is done outside a loop so it's a wee bit faster. Signed-off-by: Lisa Seelye <lisa@users.noreply.github.com>
openshift-ci-robot
added
the
approved
Contributor
Author
|
/cc @dustman9000 |
wgordon17
reviewed
Feb 11, 2021
| ret.UID = request.AdmissionRequest.UID | ||
| return ret | ||
| } | ||
| if utils.SliceContains("dedicated-admins", request.UserInfo.Groups) && |
There was a problem hiding this comment.
Does this need to also accounts for cluster-admins users?
Contributor
Author
There was a problem hiding this comment.
If that's in the spec, yes. Let's chat Tuesday.
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, lisa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow
CustomDomainobjects frommanaged.openshift.ioto bemanaged by members of the dedicated-admins group. This will also
slightly modify the logic of the
MustGathersection to refer to theApiGroup as well as the Kind (for future safety), and switch them to
being references to constants. Further, the check is done outside a loop
so it's a wee bit faster.
Signed-off-by: Lisa Seelye lisa@users.noreply.github.com