OCPBUGS-7874: set the pause exec path for openshift pod image #1424
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@zshi-redhat: This pull request references Jira Issue OCPBUGS-7874, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@zshi-redhat: This pull request references Jira Issue OCPBUGS-7874, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
openshift pod image places pause exec under /usr/bin/pod while the default path for pause exec is set to "/pause". Signed-off-by: Zenghui Shi <zshi@redhat.com>
zshi-redhat
force-pushed
the
OCPBUGS-7874
branch
from
03cdb0c to
9623f5c
Compare
|
@mrunalp @haircommander could I get one of you to take a look at these changes for us, please? |
There was a problem hiding this comment.
Can we add a comment in the file on why these settings are added? There's nothing in the description of the PR.
There was a problem hiding this comment.
I added the comment in the commit message.
There was a problem hiding this comment.
I believe this option is no longer needed
There was a problem hiding this comment.
this value is the default, why are we specifying manually?
There was a problem hiding this comment.
I copied it from openshift crio config: https://github.com/openshift/machine-config-operator/blob/cbd7d9514d6a03c84192058edae7a6ff4f9d6941/templates/master/01-master-container-runtime/_base/files/crio.yaml#L34
removed it in the new PR version.
set the following crio runtime config to be the same as openshift: - default_env - default_sysctls - absent_mount_sources_to_reject default_env sets NSS_SDB_USE_CACHE=false within containers due to https://bugzilla.redhat.com/show_bug.cgi?id=1832403 default_sysctls setting enables the ping_group_range sysctl so that we can still use ping with NET_RAW capability dropped absent_mount_sources_to_reject setting rejects /etc/hostname mount if absent, otherwise we create /etc/hostname as a directory which causes issues on reboot Signed-off-by: Zenghui Shi <zshi@redhat.com>
zshi-redhat
force-pushed
the
OCPBUGS-7874
branch
from
9623f5c to
d77e6fb
Compare
|
/retest |
|
/lgtm thank you! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, zshi-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@zshi-redhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@zshi-redhat: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-7874 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
openshift pod image places pause exec under /usr/bin/pod while the default path for pause exec is set to "/pause".