USHIFT-6164: Enable TLSv1.3 for release scenarios #5569
Conversation
openshift-ci
bot
added
the
approved
...-blueprints-bootc/layer1-base/group4/rhel96-bootc-brew-ec-with-optional-tlsv13.containerfile
Outdated
Show resolved
Hide resolved
kasturinarra
force-pushed
the
USHIFT-6164
branch
from
f8bde57 to
29ae28b
Compare
|
/test e2e-aws-tests-bootc-release |
|
@pacevedom @agullon could you please help review again ? thanks !! |
kasturinarra
force-pushed
the
USHIFT-6164
branch
from
689a9bb to
985f1a2
Compare
kasturinarra
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@kasturinarra: This pull request references USHIFT-6164 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| run_command_on_vm host1 "sudo systemctl restart microshift" | ||
|
|
||
| # Wait for MicroShift to be ready | ||
| wait_for_microshift host1 |
There was a problem hiding this comment.
can you point me to this function? it looks like it does not exist
|
|
||
| # Sourced from scenario.sh and uses functions defined there. | ||
|
|
||
| start_image="rhel96-bootc-brew-${LATEST_RELEASE_TYPE}" |
There was a problem hiding this comment.
This image does not exist, for this reason the test are not being executed:
+ 10:36:14.297508226 microshift/_output/scenarios-bootc/el96-lrel@tlsv13.sh:9 echo 'Image '\''rhel96-bootc-brew-ec'\'' not found - skipping test'
Image 'rhel96-bootc-brew-ec' not found - skipping test
| start_image="rhel96-bootc-brew-${LATEST_RELEASE_TYPE}" | |
| start_image="rhel96-bootc-brew-${LATEST_RELEASE_TYPE}-with-optional" |
There was a problem hiding this comment.
Done. addressed.
kasturinarra
force-pushed
the
USHIFT-6164
branch
from
985f1a2 to
3f85c8e
Compare
|
/test e2e-aws-tests-arm |
|
@agullon could you please help review again ? comments addressed and all tests have passed. |
|
@kasturinarra why did you decide it to run |
Nothing specific about it, i can add standarad2 as well , would you like me to add it ? |
Yes, please. I'd like to have both standard suites. Everything else looks good to me, btw. |
kasturinarra
force-pushed
the
USHIFT-6164
branch
from
3f85c8e to
da33ce0
Compare
|
/test e2e-aws-tests-bootc-release |
|
/test e2e-aws-tests-bootc /test e2e-aws-tests-release /test e2e-aws-tests-bootc-release-arm |
| run_tests host1 \ | ||
| --variable "EXPECTED_OS_VERSION:9.6" \ | ||
| --exclude tls-configuration \ | ||
| suites/standard1/ suites/standard2/ suites/selinux/validate-selinux-policy.robot |
There was a problem hiding this comment.
Both standard1 and standard2 can not be executed in the same scenario because they take more than 30 mins to run. Each of them takes about 25 mins. There's a default timeout set to 30 min.
To solve this, I suggest splitting this scenario in 2, for example: el96-lrel@tlsv13_standard1.sh and el96-lrel@tlsv13_standard2.sh.
| run_tests host1 \ | ||
| --variable "EXPECTED_OS_VERSION:9.6" \ | ||
| --exclude tls-configuration \ | ||
| suites/standard1/ suites/standard2/ suites/selinux/validate-selinux-policy.robot |
There was a problem hiding this comment.
Both standard1 and standard2 can not be executed in the same scenario because they take more than 30 mins to run. Each of them takes about 25 mins. There's a default timeout set to 30 min.
To solve this, I suggest splitting this scenario in 2, for example: el96-lrel@tlsv13_standard1.sh and el96-lrel@tlsv13_standard2.sh.
kasturinarra
force-pushed
the
USHIFT-6164
branch
from
da33ce0 to
439349b
Compare
|
/test e2e-aws-tests |
kasturinarra
force-pushed
the
USHIFT-6164
branch
from
439349b to
d20b564
Compare
|
/test e2e-aws-tests-release |
|
/test e2e-aws-tests-release |
1 similar comment
|
/test e2e-aws-tests-release |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by ci |
openshift-ci-robot
added
the
verified
|
@kasturinarra: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kasturinarra: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.20 |
|
@kasturinarra: new pull request created: #5618 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Which issue(s) this PR addresses: PR enables TLSv1.3 profile for release scenarios
Closes #USHIFT-6164