Skip to content

Conversation

oglok
Copy link
Contributor

@oglok oglok commented Sep 21, 2022

These two APIs are not available in MicroShift, so informers are useless here.

  These APIs are not available

Signed-off-by: Ricardo Noriega <rnoriega@redhat.com>
Signed-off-by: Ricardo Noriega <rnoriega@redhat.com>
@oglok oglok requested review from benluddy and stlaz September 21, 2022 12:15
@openshift-ci openshift-ci bot requested review from copejon and mangelajo September 21, 2022 12:16
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2022
@stlaz
Copy link
Contributor

stlaz commented Sep 27, 2022

The removal of RBR controller LGTM.

@benluddy please chime in on the cluster quotas

@mangelajo
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangelajo, oglok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oglok
Copy link
Contributor Author

oglok commented Sep 30, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2022

@oglok: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/periodic-ocp-4.13-images 8e28639 link true /test periodic-ocp-4.13-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oglok
Copy link
Contributor Author

oglok commented Oct 31, 2022

Closing this PR because a fix directly in OCP would be preferred instead of a carried patch like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants