Skip to content

Conversation

@DavidRajnoha
Copy link
Contributor

This PR extends the comprehensive charts UI regression test to verify that short duration incidents (<5 minutes) are properly visible and selectable in the charts view.

Changes:

  • Enhanced charts UI comprehensive test with short duration incident scenarios (1-min and 10-min incidents)
  • Added selectIncidentById and deselectIncidentById methods to the incidents page object
  • Refactored and simplified test fixture for better maintainability
  • Ensures proper bar rendering and alert loading for brief incidents

Test Coverage:

  • Validates visibility of short-lived incidents in charts
  • Tests incident selection/deselection functionality
  • Verifies correct rendering of incident bars for varying durations

… test

Extend comprehensive charts UI test to verify short duration incidents
(<5min) are visible and selectable. Adds scenarios for 1-min and 10-min
incidents with proper bar rendering and alert loading verification.

Updates test fixture and adds selectIncidentById/deselectIncidentById
page object methods for incident selection.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 31, 2025

@DavidRajnoha: This pull request references OBSINTA-777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

This PR extends the comprehensive charts UI regression test to verify that short duration incidents (<5 minutes) are properly visible and selectable in the charts view.

Changes:

  • Enhanced charts UI comprehensive test with short duration incident scenarios (1-min and 10-min incidents)
  • Added selectIncidentById and deselectIncidentById methods to the incidents page object
  • Refactored and simplified test fixture for better maintainability
  • Ensures proper bar rendering and alert loading for brief incidents

Test Coverage:

  • Validates visibility of short-lived incidents in charts
  • Tests incident selection/deselection functionality
  • Verifies correct rendering of incident bars for varying durations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@etmurasaki
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidRajnoha, etmurasaki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2025
@etmurasaki
Copy link
Contributor

/label ux-approved
/label qe-approved

@openshift-ci openshift-ci bot added ux-approved Signifies that UX has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Nov 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2025

@DavidRajnoha: This pull request references OBSINTA-777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

This PR extends the comprehensive charts UI regression test to verify that short duration incidents (<5 minutes) are properly visible and selectable in the charts view.

Changes:

  • Enhanced charts UI comprehensive test with short duration incident scenarios (1-min and 10-min incidents)
  • Added selectIncidentById and deselectIncidentById methods to the incidents page object
  • Refactored and simplified test fixture for better maintainability
  • Ensures proper bar rendering and alert loading for brief incidents

Test Coverage:

  • Validates visibility of short-lived incidents in charts
  • Tests incident selection/deselection functionality
  • Verifies correct rendering of incident bars for varying durations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 851e288 and 2 for PR HEAD 5826bdb in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@DavidRajnoha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 5826bdb link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 342abc3 and 1 for PR HEAD 5826bdb in total

@openshift-merge-bot openshift-merge-bot bot merged commit 6f048b6 into openshift:main Nov 19, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants