-
Notifications
You must be signed in to change notification settings - Fork 35
OBSINTA-777: [Incidents] Regression tests for short incidents visualisation #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSINTA-777: [Incidents] Regression tests for short incidents visualisation #623
Conversation
… test Extend comprehensive charts UI test to verify short duration incidents (<5min) are visible and selectable. Adds scenarios for 1-min and 10-min incidents with proper bar rendering and alert loading verification. Updates test fixture and adds selectIncidentById/deselectIncidentById page object methods for incident selection.
|
@DavidRajnoha: This pull request references OBSINTA-777 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidRajnoha, etmurasaki The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label ux-approved |
|
@DavidRajnoha: This pull request references OBSINTA-777 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@DavidRajnoha: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR extends the comprehensive charts UI regression test to verify that short duration incidents (<5 minutes) are properly visible and selectable in the charts view.
Changes:
selectIncidentByIdanddeselectIncidentByIdmethods to the incidents page objectTest Coverage: