Skip to content

CFE-250 - Fix linting issues #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2022
Merged

CFE-250 - Fix linting issues #12

merged 2 commits into from
Mar 10, 2022

Conversation

sherine-k
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from arjunrn and lmzuccarelli March 9, 2022 13:53
@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2022

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

lmzuccarelli
lmzuccarelli reviewed Mar 10, 2022
View reviewed changes
Copy link
Contributor

@lmzuccarelli lmzuccarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sherine - great now we are aligned on both the operator and agent

@lmzuccarelli
Copy link
Contributor

@Sherine - question , the changes in the go code were they related to linting ?

@sherine-k
Copy link
Contributor Author

sherine-k commented Mar 10, 2022 •
edited
Loading

question , the changes in the go code were they related to linting ?

Yes, golint complains when any function or variable is public but not preceded by a comment... So I reviewed all the things in pkg/handlers that are not used outside that package, and made them private

@lmzuccarelli
Copy link
Contributor

@Sherine - great thanks for the feeedback

@lmzuccarelli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022
@openshift-merge-robot openshift-merge-robot merged commit ab4d950 into openshift:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arjunrn arjunrn Awaiting requested review from arjunrn

1 more reviewer

@lmzuccarelli lmzuccarelli lmzuccarelli left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lmzuccarelli lmzuccarelli

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sherine-k @lmzuccarelli @openshift-merge-robot